Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: mgr/cephadm: support for miscellaneous config files for daemons #51517

Merged
merged 4 commits into from May 25, 2023

Conversation

adk3798
Copy link
Contributor

@adk3798 adk3798 commented May 16, 2023

backport of #46883
parent tracker: https://tracker.ceph.com/issues/56394

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 61a6ec0)

Conflicts:
	src/python-common/ceph/deployment/drive_group.py
	src/python-common/ceph/deployment/service_spec.py
Fixes: https://tracker.ceph.com/issues/56394

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit de43dab)

Conflicts:
	src/cephadm/cephadm
	src/pybind/mgr/cephadm/services/cephadmservice.py
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 78598ea)

Conflicts:
	src/pybind/mgr/cephadm/tests/test_cephadm.py
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit fa08b55)

Conflicts:
	doc/cephadm/services/index.rst
@adk3798
Copy link
Contributor Author

adk3798 commented May 24, 2023

https://pulpito.ceph.com/adking-2023-05-21_23:31:07-orch:cephadm-wip-adk4-testing-2023-05-21-1612-pacific-distro-default-smithi/

Reruns of failed/dead jobs: https://pulpito.ceph.com/adking-2023-05-22_14:03:36-orch:cephadm-wip-adk4-testing-2023-05-21-1612-pacific-distro-default-smithi/

6 failures, 1 dead job:

  • 2 failures were the dashboard e2e test, which is known to fail in pacific runs
  • the test_rbd_api, smoke start jobs that failed and the nfs-ingress-rgw-bucket test that failed appear to be infra/teuthology failures with connecting to nodes or installing packages
  • The two test_nfs failures seem to be an issue with the test. From the logs saw
2023-05-22T14:39:09.670 DEBUG:teuthology.orchestra.run.smithi071:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph n f s ' ' c l u s t e r ' ' c r e a t e ' ' t e s t
2023-05-22T14:39:10.228 INFO:teuthology.orchestra.run.smithi071.stderr:no valid command found; 10 closest matches:
2023-05-22T14:39:10.228 INFO:teuthology.orchestra.run.smithi071.stderr:pg stat
2023-05-22T14:39:10.228 INFO:teuthology.orchestra.run.smithi071.stderr:pg getmap
2023-05-22T14:39:10.229 INFO:teuthology.orchestra.run.smithi071.stderr:pg dump [all|summary|sum|delta|pools|osds|pgs|pgs_brief...]
2023-05-22T14:39:10.229 INFO:teuthology.orchestra.run.smithi071.stderr:pg dump_json [all|summary|sum|pools|osds|pgs...]
2023-05-22T14:39:10.229 INFO:teuthology.orchestra.run.smithi071.stderr:pg dump_pools_json
2023-05-22T14:39:10.229 INFO:teuthology.orchestra.run.smithi071.stderr:pg ls-by-pool <poolstr> [<states>...]
2023-05-22T14:39:10.230 INFO:teuthology.orchestra.run.smithi071.stderr:pg ls-by-primary <id|osd.id> [<pool:int>] [<states>...]
2023-05-22T14:39:10.230 INFO:teuthology.orchestra.run.smithi071.stderr:pg ls-by-osd <id|osd.id> [<pool:int>] [<states>...]
2023-05-22T14:39:10.230 INFO:teuthology.orchestra.run.smithi071.stderr:pg ls [<pool:int>] [<states>...]
2023-05-22T14:39:10.231 INFO:teuthology.orchestra.run.smithi071.stderr:pg dump_stuck [inactive|unclean|stale|undersized|degraded...] [<threshold:int>]
2023-05-22T14:39:10.231 INFO:teuthology.orchestra.run.smithi071.stderr:Error EINVAL: invalid command
2023-05-22T14:39:10.231 DEBUG:teuthology.orchestra.run:got remote process result: 22

so it looks like something is mangling the ceph nfs cluster create command to instead be ceph n f s ' ' c l u s t e r ' ' c r e a t e ' ' t e s t which obviously doesn't work. Something that should be fixed, but shouldn't block merging of any of the PRs in the run.

Overall, should be okay to merge the PRs in the run

@adk3798
Copy link
Contributor Author

adk3798 commented May 24, 2023

jenkins test make check

@adk3798 adk3798 merged commit c2b714e into ceph:pacific May 25, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants