Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: fix Nan undefined values and add empty pipe on expand-cluster #51562

Merged
merged 1 commit into from
May 22, 2023

Conversation

Pegonzal
Copy link
Contributor

In many places around the dashboard the value NaN undefined was being shown, fixed to show N/A when needed

Before:
image

Now:

image

Fixes: https://tracker.ceph.com/issues/61207
Signed-off-by: Pedro Gonzalez Gomez pegonzal@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Pegonzal Pegonzal requested a review from a team as a code owner May 18, 2023 11:54
@Pegonzal Pegonzal requested review from pereman2 and aaSharma14 and removed request for a team May 18, 2023 11:54
@nizamial09
Copy link
Member

@Pegonzal the commit doesn't have the tracker attached!

…cluster

Fixes: https://tracker.ceph.com/issues/61207
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
@Pegonzal
Copy link
Contributor Author

@Pegonzal the commit doesn't have the tracker attached!

Fixed it

@nizamial09 nizamial09 merged commit 633279b into ceph:main May 22, 2023
8 of 13 checks passed
@nizamial09 nizamial09 deleted the fix-nan-undefined-values branch May 22, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants