reef: mgr/cephadm: support for nfs backed by VIP #51614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/55663 Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit bb0a0f9)
Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 5de3312)
Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit e104fdc)
Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit e905830)
…g arbitrary hosts For now, just for linking ingress services and their backend services. The idea is if one, or both, of the ingress service and backend service is using a count, to try and get them to deploy their daemons on the same host(s). If the placements have explicit placements (not using count) we still stick to those placements regardless. This should enable something like specifying a host for the backend service and leaving the ingress placement as just "count: 1" and having the ingress service get on the same host as the backend service daemon. This is particularly useful for the keepalive-only (VIP but no haproxy) over NFS setup where the keepalive must share a host with the NFS to function, but will also be useful for other VIP only setups we may do in the future. Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 088d2c4)
|
This should not be merged without the addition of #51393 |
This was recently added in ceph@088d2c4 and seems to work fine, but logging these things at info level spams the log as every single service every serve loop iteration is reporting on whether it has related daemons. This changes it to only log when it finds related daemons or when it prefers a host due to those related daemons, and do both of those at only debug level. Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 3693544)
the commit from this PR has now been added |
|
jenkins test make check |
|
Failures:
Overall, nothing that should block merging any of the backports |
rkachach
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59631
backport of #47199
parent tracker: https://tracker.ceph.com/issues/55663
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh