Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/rados: edit filestore-config-ref.rst #51745

Conversation

zdover23
Copy link
Contributor

@zdover23 zdover23 commented May 25, 2023

Edit doc/rados/configuration/filestore-config-ref.rst.

https://tracker.ceph.com/issues/58485

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Edit doc/rados/configuration/filestore-config-ref.rst.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
.. note:: Since the Luminous release of Ceph, Filestore has not been Ceph's
default storage back end. Since the Luminous release of Ceph, BlueStore has
been Ceph's default storage back end. However, Filestore OSDs are still
supported. See :ref:`OSD Back Ends
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we decide that as of Reef they aren't supported, as in code is being removed? Should we instead condense this entire file to directing the gentle reader to redeploy OSDs before upgrading to Reef?
#50657
#51682

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthonyeleven: This PR is one is a series that I have labeled "FileStore deprecation". A future pull request (like, a near-future pull request, probably next week if not tomorrow) will hit every place in the documentation suite and communicate the idea that it's time to redeploy OSDs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that be soon enough that Reef won't release claiming that Filestore is still supported? To be clear, I'm saying that the ONLY thing to be left in this file for Reef and main should be an admonition to redeploy OSDs before upgrading.

Copy link
Contributor Author

@zdover23 zdover23 May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that be soon enough that Reef won't release claiming that Filestore is still supported? To be clear, I'm saying that the ONLY thing to be left in this file for Reef and main should be an admonition to redeploy OSDs before upgrading.

Yes, it will be soon enough that Reef will release with documentation that informs readers that Filestore is not supported at all in Reef.

Here's what's going on here: this is (probably) the final commit affecting this file before I have to start keeping two sets of books for (at least) the RADOS docs. One set of future books will be a Reef-(inclusive)-and-future-releases set that mentions Filestore only to warn people away from it and to let them know that Filestore is defunct, and the other set of future books is a Quincy-and-back-in-time-to-possibly-as-far-back-as-Luminous set that still presents Filestore as a supported storage back end. This commit gets the text into good-enough-by-the-standards-of-English grammar shape that I won't have to edit the extant English in both branches of the bifurcation that is about to occur.

There is a similar do-this-here-and-do-that-there issue vis-à-vis cache tiering. Step one: kill as many doubleton birds with one stone as possible. Step two: contend with the surviving singletons.

performance. To implement such an extrinsic method, refer to the following
settings.

If the underlying file system has no size limit, then Ceph XATTRs are stored as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this whole section. If not, I think only EXT4 has the XATTRs issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neha-ojha @jdurgin: What say you?

@zdover23 zdover23 merged commit b1c45df into ceph:main May 25, 2023
12 of 16 checks passed
@zdover23
Copy link
Contributor Author

#51751 - Reef backport
#51752 - Quincy backport
#51753 - Pacific backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants