Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: D3N: cache objects which oid contains slash #51819

Merged
merged 1 commit into from Jun 22, 2023

Conversation

mkogan1
Copy link
Contributor

@mkogan1 mkogan1 commented May 29, 2023

allow D3N caching of objects names for example:

sudo ./bin/rados ls -p default.rgw.buckets.data
...
ec43cdb3-59d1-4304-8511-9a3c180f048b.4231.3__shadow_warehouse/cephs3/parkingcitations/parkingcitations_5.csv.2~wcGD_MF_W9hEBAV8x3l9uHKHKQC5_mn.88_1
ec43cdb3-59d1-4304-8511-9a3c180f048b.4231.3__shadow_warehouse/cephs3/parkingcitations/parkingcitations_2.csv.2~eJyQZhfiayNv9Z-27_IfUb4mDwQnSmv.4_1
ec43cdb3-59d1-4304-8511-9a3c180f048b.4231.3__shadow_warehouse/cephs3/parkingcitations/parkingcitations_3.csv.2~VY905gVNZ-nXxfBLgko84z1TUv_c74f.85_
                                                             ^      ^

after this PR:

ls -lh /mnt/nvme/rgw_datacache
...
-rw-r--r-- 1 root root 4.0M May 29 13:55 ec43cdb3-59d1-4304-8511-9a3c180f048b.4231.3__shadow_warehouse%2Fcephs3%2Fparkingcitations%2Fparkingcitations_5.csv.2~wcGD_MF_W9hEBAV8x3l9uHKHKQC5_mn.99_1
-rw-r--r-- 1 root root 4.0M May 29 13:55 ec43cdb3-59d1-4304-8511-9a3c180f048b.4231.3__shadow_warehouse%2Fcephs3%2Fparkingcitations%2Fparkingcitations_5.csv.2~wcGD_MF_W9hEBAV8x3l9uHKHKQC5_mn.99_2
-rw-r--r-- 1 root root 3.0M May 29 13:55 ec43cdb3-59d1-4304-8511-9a3c180f048b.4231.3__shadow_warehouse%2Fcephs3%2Fparkingcitations%2Fparkingcitations_5.csv.2~wcGD_MF_W9hEBAV8x3l9uHKHKQC5_mn.99_3

and refactor to clean up the D3N storage location variables for uniformity.
(manual testing for the correctness of cache writing->reading->expiration were performed)

Fixes: https://tracker.ceph.com/issues/59739

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@mkogan1
Copy link
Contributor Author

mkogan1 commented May 31, 2023

@mkogan1
Copy link
Contributor Author

mkogan1 commented May 31, 2023

@dang @mattbenjamin @samarahu @pritha-srivastava
FYI, just a heards up - object names with a 'slash' in the name can occur,
in this case they were created by Trino

ex:

sudo ./bin/rados ls -p default.rgw.buckets.data
...
ec43cdb3-59d1-4304-8511-9a3c180f048b.4231.3__shadow_warehouse/cephs3/parkingcitations/parkingcitations_3.csv.2~VY905gVNZ-nXxfBLgko84z1TUv_c74f.85_
                                                             ^      ^

@mkogan1
Copy link
Contributor Author

mkogan1 commented May 31, 2023

jenkins test make check

@mkogan1
Copy link
Contributor Author

mkogan1 commented Jun 8, 2023

jenkins test make check arm64

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@mkogan1
Copy link
Contributor Author

mkogan1 commented Jun 19, 2023

rebased because of merge-conflicts

@mkogan1
Copy link
Contributor Author

mkogan1 commented Jun 20, 2023

@cbodley is it OK to merge or does it need another teuthology run?

@mkogan1
Copy link
Contributor Author

mkogan1 commented Jun 22, 2023

per discussion in the bug scrub, ok to merge

@mkogan1 mkogan1 merged commit bcf5df8 into ceph:main Jun 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants