librbd: avoid decrementing iterator before first element #51828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Make this |
While trying to merge delayed requests, SimpleSchedulerObjectDispatch can end up iterating before the first element. With llvm, this leads to a crash: https://paste.opendev.org/raw/bxnQqqDtIrkOfVvRfkZ6/ This change adds a check, ensuring that we won't decrement the iterator before the first map element. Fixes: https://tracker.ceph.com/issues/61503 Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94
force-pushed
the
it_decrement_issue
branch
from
9d21a32
to
ca65e85
Compare
This scenario is actually covered by |
idryomov
approved these changes
May 30, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to merge delayed requests, SimpleSchedulerObjectDispatch can end up iterating before the first element.
With llvm, this leads to a crash:
https://paste.opendev.org/raw/bxnQqqDtIrkOfVvRfkZ6/
This change adds a check, ensuring that we won't decrement the iterator before the first map element.
Fixes: https://tracker.ceph.com/issues/61503
Signed-off-by: Lucian Petrut lpetrut@cloudbasesolutions.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows