client: do not send metrics until the MDS rank is ready #51850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dparmar18
reviewed
May 31, 2023
lxbsz
force-pushed
the
wip-61523
branch
3 times, most recently
from
a6bef3e
to
a2be5ec
Compare
|
@dparmar18 just remind me this code location in the function and I just moved it in front of the Thanks @dparmar18 |
joscollin
reviewed
Jun 1, 2023
There was a problem hiding this comment.
I think it's better to have these checks in the next tick
https://github.com/ceph/ceph/blob/main/src/client/Client.cc#L6868
Sound good to me and will fix it. Thanks @joscollin |
dparmar18
reviewed
Jun 1, 2023
In some cases when there are a lot of clients and these clients have a lots of known requests need to replay too, the metrics requests will be dropped by the MDS because the MDS is still in the clientreplay state, and also the useless metric requests will slow down MDS. Fixes: https://tracker.ceph.com/issues/61523 Signed-off-by: Xiubo Li <xiubli@redhat.com>
dparmar18
approved these changes
Jun 1, 2023
|
@rishabh-d-dave please take this one. |
vshankar
added
wip-vshankar-testing4
and removed
wip-rishabh-testing
@rishabh-d-dave Included this in my test branch. |
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases when there are a lot of clients and these clients have a lots of known requests need to replay too, the metrics requests will be dropped by the MDS because the MDS is still in the clientreplay state, and also the useless metric requests will slow down MDS.
Fixes: https://tracker.ceph.com/issues/61523
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows