pacific: osd/OSDCap: allow rbd.metadata_list method under rbd-read-only profile #51876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in commit acc447d ("osd/OSDCap: rbd profile permits use of rbd.metadata_list cls method") which adjusted only "profile rbd" OSD cap. Listing image metadata is an essential part of opening the image and "profile rbd-read-only" OSD cap must allow it too. While at it, constrain the existing grant for rbd profile from "any object in the pool" to just "rbd_info object in the global namespace of the pool" as this is where pool-level image metadata actually lives. Fixes: https://tracker.ceph.com/issues/61382 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit b580cda)
trociny
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/61528
backport of #51814
parent tracker: https://tracker.ceph.com/issues/61382