Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reef: crimson/osd/ops_executer: fix double apply_stats() when writing #51918

Merged
merged 1 commit into from Jun 15, 2023

Conversation

rosinL
Copy link
Member

@rosinL rosinL commented Jun 5, 2023

As double apply_stats() when writing, the write related metrics such as the object number and space utilization are doubled. Therefore, just do once in ops executing process.

Fixes: https://tracker.ceph.com/issues/61227

Signed-off-by: luo rixin luorixin@huawei.com
(cherry picked from commit 1dd1847)

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

As double apply_stats() when writing, the write related metrics such as
the object number and space utilization are doubled. Therefore, just do once in
ops executing process.

Fixes: https://tracker.ceph.com/issues/61227

Signed-off-by: luo rixin <luorixin@huawei.com>
(cherry picked from commit 1dd1847)
@rosinL rosinL requested a review from a team as a code owner June 5, 2023 10:41
@github-actions github-actions bot added this to the reef milestone Jun 5, 2023
@rosinL
Copy link
Member Author

rosinL commented Jun 5, 2023

@Matan-B please help to review

@ljflores
Copy link
Contributor

@yuriw yuriw merged commit b113bd2 into ceph:reef Jun 15, 2023
14 of 15 checks passed
@rosinL rosinL deleted the wip-51746-reef branch June 16, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants