doc/rados: edit change-mon-elections #51992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyeleven
approved these changes
Jun 10, 2023
| You can disallow a leader by running: | ||
| The modes other than ``classic`` provide extra features. We recommend staying | ||
| in ``classic`` mode if you don't need these extra features because it is the | ||
| simplest mode. |
There was a problem hiding this comment.
Suggest s/extra/specific/ so the uncareful reader is perhaps less inclined to disregard advice.
There was a problem hiding this comment.
I think all three of these suggestions are clear improvements. They're all accepted.
| you can forget history and reset them by running: | ||
| Connectivity scores are expected to remain valid. However, if during | ||
| troubleshooting you determine that these scores have for some reason become | ||
| invalid, forget the history and reset the scores by running a command of the |
There was a problem hiding this comment.
Suggest s/forget/drop/ but this is marginal.
| Resetting connectivity scores carries little risk: monitors will still quickly | ||
| determine whether a connection is alive or dead and trend back to the previous | ||
| scores if those scores were accurate. Nevertheless, resetting scores ought to | ||
| be unnecessary and it is not recommended unless requested by your support team |
There was a problem hiding this comment.
s/requested/advised/, again marginal.
Edit doc/rados/operations/change-mon-elections.rst. https://tracker.ceph.com/issues/58485 Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com> Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23
force-pushed
the
wip-doc-2023-06-10-rados-operations-change-mon-elections
branch
from
d52c56f
to
dc93181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit doc/rados/operations/change-mon-elections.rst.
https://tracker.ceph.com/issues/58485
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows