New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa: wait for file to have correct size #51995
Conversation
Otherwise suspending the netns of the other mount will prevent it from completing a flush on the file handle or even telling the MDS that the file size has changed! Fixes: https://tracker.ceph.com/issues/61409 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
main: https://pulpito.ceph.com/pdonnell-2023-06-10_18:19:40-fs:functional-main-distro-default-smithi/ main + this PR: https://pulpito.ceph.com/pdonnell-2023-06-10_18:20:34-fs:functional-main-distro-default-smithi/ The failure is: https://tracker.ceph.com/issues/57682 The other tests do not fail without this PR because it's a racy test. It's only easily reproduced in combination with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins test api |
@@ -383,7 +385,6 @@ def test_filelock(self): | |||
|
|||
self.mount_b.check_filelock(do_flock=flockable) | |||
|
|||
# Tear down the background process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removal of these comments is intentional right? Looks too trivial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. They're ultra-redundant.
Otherwise suspending the netns of the other mount will prevent it from completing a flush on the file handle or even telling the MDS that the file size has changed!
Fixes: https://tracker.ceph.com/issues/61409
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows