qa/rgw/s3tests: make extra_attrs additive #52156
Conversation
the s3tests.py task is filtering out several attrs by default. but when dbstore uses `extra_attrs` to add 'not fails_on_dbstore', it overwrites those other filters Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
this comment was about the old fails_strict_rfc2616 attr that was removed in 6238eaa Signed-off-by: Casey Bodley <cbodley@redhat.com>
| args += ['tox', '--', '-v', '-m', ' and '.join(attrs)] | ||
| if 'extra_args' in client_config: | ||
| args.append(client_config['extra_args']) | ||
| args += client_config.get('extra_args', []) |
There was a problem hiding this comment.
Just so I'm clear, why does this get of extra_args need to be done twice for args? In the dbstore case wouldn't args have the string not fails_on_dbstore twice in it's list at the end.
There was a problem hiding this comment.
one of the lines is extra_attrs which refers to the attrs we use for filtering with the pytest -m option
this second one is called extra_args, which can add arbitrary arguments to the pytest command line. the latter doesn't appear to be used by any suites atm
|
verified that the existing attrs are preserved in http://qa-proxy.ceph.com/teuthology/cbodley-2023-06-22_15:25:21-rgw-main-distro-default-smithi/7311778/teuthology.log:
|
|
it looks like this caused a regression in the rgw/sts subsuite:
because it requests both tracked in https://tracker.ceph.com/issues/61838 |
the s3tests.py task is filtering out several attrs by default. but when dbstore uses
extra_attrsto add 'not fails_on_dbstore', it overwrites those other filtersShow available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows