Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/s3select: s3select fixes, related to Trino/TPCDS benchmark #52186

Closed
wants to merge 3 commits into from

Conversation

galsalomon66
Copy link
Contributor

@galsalomon66 galsalomon66 commented Jun 25, 2023

the Trino & TPCDS discovered issues related to the push-down s3select statements.
some of the statements had failed the syntax phase, and some had failed on runtime.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@galsalomon66 galsalomon66 requested a review from a team as a code owner June 25, 2023 22:11
@galsalomon66
Copy link
Contributor Author

@galsalomon66 galsalomon66 changed the title s3select fixes, related to Trino/TPCDS benchmark rgw/s3select: s3select fixes, related to Trino/TPCDS benchmark Jun 26, 2023
@cbodley
Copy link
Contributor

cbodley commented Jun 26, 2023

Unmodified Submodules — Approval needed: modified submodules found
please include 's3select submodule' in your commit message, if this change is intentional.

@galsalomon66
Copy link
Contributor Author

https://pulpito.ceph.com/gsalomon-2023-06-28_11:42:16-rgw:verify-trino_tpcds_issues-distro-default-smithi/
8 passed successfully
the failed and dead jobs do not seem related to s3select changes, including the valgrind reports.

@galsalomon66
Copy link
Contributor Author

galsalomon66 commented Jul 3, 2023

http://pulpito.front.sepia.ceph.com/gsalomon-2023-07-03_07:27:35-rgw:verify-trino_tpcds_issues-distro-default-smithi/
all 12 jobs had failed.
failures are not related to PR changes (all related tests had passed successfully)

s3select fixes, related to Trino/TPCDS benchmark

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
add log-message for better tracing the flow timeline

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
updated s3select-engine

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
@galsalomon66
Copy link
Contributor Author

@galsalomon66
Copy link
Contributor Author

move to #52651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants