pacific: pybind/mgr/devicehealth: do not crash if db not ready #52214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a remote method called by telemtry so the @CLIRequiresDB decorator isn't appropriate. Fixes: https://tracker.ceph.com/issues/56239 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 3057068) Conflicts: src/pybind/mgr/devicehealth/module.py: import conflict
|
retest this please |
1 similar comment
|
retest this please |
ljflores
approved these changes
Aug 8, 2023
|
jenkins retest this please |
|
I forgot this PR is not necessary as @yuriw let this be a lesson to you not to include PRs with failing jenkins tests in your QA runs. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/61835
backport of #51858
parent tracker: https://tracker.ceph.com/issues/56239
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh