rgw: Add coverity uninitialized variable and initialize RGWBucketEntryMetadataObject #52254

vedanshbhartia · 2023-06-29T10:59:25Z

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

github-actions · 2023-06-29T11:11:23Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

yuvalif · 2023-07-03T09:40:14Z

@vedanshbhartia could you please squash the commits?

yuvalif · 2023-07-03T09:40:40Z

jenkins test api

yuvalif · 2023-07-03T09:52:24Z

src/rgw/driver/rados/rgw_bucket.cc

@@ -1656,7 +1656,7 @@ class RGWBucketMetadataHandler : public RGWBucketMetadataHandlerBase {
 class RGWMetadataHandlerPut_Bucket : public RGWMetadataHandlerPut_SObj
 {
  RGWBucketMetadataHandler *bhandler;
-  RGWBucketEntryMetadataObject *obj;
+  RGWBucketEntryMetadataObject *obj = nullptr;


are you sure this is the correct behavior?
maybe the right fix is to pass _obj to the ctor of RGWMetadataHandlerPut_SObj?

RGWMetadataHandlerPut_SObj doesn't have the context of obj though, it is defined in RGWMetadataHandlerPut_Bucket.

so, why do we pass it to the RGWMetadataHandlerPut_SObj constructor?

obj is ultimately used to initialize another RGWMetadataObject inside RGWMetadataHandler_GenericMetaBE::Put::Put

ok. but this is still an issue.
we pass nullptr to RGWMetadataHandler_GenericMetaBE::Put::Put but store the object pointer to RGWMetadataHandlerPut_Bucket.
we should probably try to ask what is the right fix.

@kalebskeithley this was done as part of 5ba9842
should we pass _obj to RGWMetadataHandlerPut_SObj ?

@vedanshbhartia could you please fix as discussed?

yuvalif · 2023-07-03T09:59:13Z

src/rgw/rgw_rest_conn.cc

@@ -124,6 +124,7 @@ int RGWRESTConn::forward_iam_request(const DoutPrefixProvider *dpp, const RGWAcc
  }
  std::string service = "iam";
  RGWRESTSimpleRequest req(cct, info.method, url, NULL, &params, api_name);
+  // coverity[uninit_use_in_call:SUPPRESS]


on which uninitialized variable was the complaint?

req.api_name

yuvalif · 2023-07-03T10:00:21Z

src/rgw/rgw_rest_conn.cc

@@ -143,6 +144,7 @@ int RGWRESTConn::put_obj_send_init(const rgw_obj& obj, const rgw_http_param_pair
  }

  RGWRESTStreamS3PutObj *wr = new RGWRESTStreamS3PutObj(cct, "PUT", url, NULL, &params, api_name, host_style);
+  // coverity[uninit_use_in_call:SUPPRESS]


on which uninitialized variable was the complaint?

wr->api_name, which is an optional string. Coverity was complaining about an internal member of the optional string
Coverity issue ID 1521574

ok. got it. so, this is a know coverity bug to treat std::optional as uninit

yuvalif · 2023-07-03T10:01:30Z

src/rgw/rgw_rest_conn.cc

@@ -160,6 +162,7 @@ int RGWRESTConn::put_obj_async_init(const DoutPrefixProvider *dpp, const rgw_use
  param_vec_t params;
  populate_params(params, &uid, self_zone_group);
  RGWRESTStreamS3PutObj *wr = new RGWRESTStreamS3PutObj(cct, "PUT", url, NULL, &params, api_name, host_style);
+  // coverity[uninit_use_in_call:SUPPRESS]


on which uninitialized variable was the complaint?

wr->api_name, which is an optional string. Coverity was complaining about an internal member of the optional string
Coverity issue ID 1521567

yuvalif · 2023-07-03T10:02:45Z

src/rgw/rgw_rest_conn.cc

@@ -290,6 +293,7 @@ int RGWRESTConn::get_obj(const DoutPrefixProvider *dpp, const rgw_obj& obj, cons
    set_header(buf, extra_headers, "RANGE");
  }

+  // coverity[uninit_use_in_call:SUPPRESS]


on which uninitialized variable was the complaint?

req->api_name, which is an optional string.
Coverity issue ID 1521575

i don't see api_name in line 297

It's used inside the call chain of send_prepare

yuvalif · 2023-07-23T18:56:32Z

jenkins test api

github-actions · 2023-07-24T17:27:51Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

…ndlerPut_SObj correctly Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>

yuvalif · 2023-10-09T12:48:05Z

teuthology: http://pulpito.ceph.com/yuvalif-2023-10-08_18:12:17-rgw-wip-yuval-test-gsoc-distro-default-smithi/

yuvalif · 2023-10-09T14:58:23Z

teuthology: http://pulpito.ceph.com/yuvalif-2023-10-08_18:12:17-rgw-wip-yuval-test-gsoc-distro-default-smithi/

same as baseline: https://pulpito.ceph.com/yuriw-2023-10-07_14:02:30-rgw-main-distro-default-smithi/

vedanshbhartia requested a review from a team as a code owner June 29, 2023 10:59

github-actions bot added the rgw label Jun 29, 2023

vedanshbhartia force-pushed the coverity_uninit branch from 79784bd to edb1bba Compare June 29, 2023 11:11

github-actions bot added the needs-rebase label Jun 29, 2023

github-actions bot removed the needs-rebase label Jun 29, 2023

yuvalif added the GSoC / Outreachy label Jun 29, 2023

yuvalif reviewed Jul 3, 2023

View reviewed changes

yuvalif requested a review from kalebskeithley July 6, 2023 07:49

vedanshbhartia force-pushed the coverity_uninit branch from 919c594 to 338f841 Compare July 24, 2023 17:25

github-actions bot added the needs-rebase label Jul 24, 2023

vedanshbhartia force-pushed the coverity_uninit branch from 338f841 to c2d5bc6 Compare July 24, 2023 17:33

rgw: Add coverity uninitialized variable and initialize RGWMetadataHa…

c2d5bc6

…ndlerPut_SObj correctly Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>

github-actions bot removed the needs-rebase label Jul 24, 2023

yuvalif approved these changes Jul 24, 2023

View reviewed changes

yuvalif added the wip-yuval-testing label Jul 25, 2023

yuvalif merged commit d05fa0b into ceph:main Oct 9, 2023
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rgw: Add coverity uninitialized variable and initialize RGWBucketEntryMetadataObject #52254

rgw: Add coverity uninitialized variable and initialize RGWBucketEntryMetadataObject #52254

vedanshbhartia commented Jun 29, 2023

github-actions bot commented Jun 29, 2023

yuvalif commented Jul 3, 2023

yuvalif commented Jul 3, 2023

yuvalif Jul 3, 2023

vedanshbhartia Jul 3, 2023

yuvalif Jul 4, 2023

vedanshbhartia Jul 4, 2023

yuvalif Jul 4, 2023

yuvalif Jul 5, 2023

yuvalif Jul 23, 2023

vedanshbhartia Jul 24, 2023

yuvalif Jul 3, 2023

yuvalif Jul 4, 2023

vedanshbhartia Jul 4, 2023

yuvalif Jul 3, 2023

vedanshbhartia Jul 3, 2023 •

edited

yuvalif Jul 4, 2023

yuvalif Jul 3, 2023

vedanshbhartia Jul 3, 2023 •

edited

yuvalif Jul 3, 2023

vedanshbhartia Jul 3, 2023

yuvalif Jul 4, 2023

vedanshbhartia Jul 4, 2023

yuvalif commented Jul 23, 2023

github-actions bot commented Jul 24, 2023

yuvalif commented Oct 9, 2023 •

edited

yuvalif commented Oct 9, 2023

rgw: Add coverity uninitialized variable and initialize RGWBucketEntryMetadataObject #52254

rgw: Add coverity uninitialized variable and initialize RGWBucketEntryMetadataObject #52254

Conversation

vedanshbhartia commented Jun 29, 2023

Contribution Guidelines

Checklist

github-actions bot commented Jun 29, 2023

yuvalif commented Jul 3, 2023

yuvalif commented Jul 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vedanshbhartia Jul 3, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vedanshbhartia Jul 3, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuvalif commented Jul 23, 2023

github-actions bot commented Jul 24, 2023

yuvalif commented Oct 9, 2023 • edited

yuvalif commented Oct 9, 2023

vedanshbhartia Jul 3, 2023 •

edited

vedanshbhartia Jul 3, 2023 •

edited

yuvalif commented Oct 9, 2023 •

edited