Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: client: only wait for write MDS OPs when unmounting #52303

Merged
merged 2 commits into from Aug 17, 2023
Merged

quincy: client: only wait for write MDS OPs when unmounting #52303

merged 2 commits into from Aug 17, 2023

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Jul 4, 2023

backport tracker: https://tracker.ceph.com/issues/61796

backport of #51417
parent tracker: https://tracker.ceph.com/issues/59705

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

lxbsz added 2 commits July 4, 2023 09:47
@lxbsz
client: flush the mdlog before waiting for unsafe requests
fd8a8a3 
For safe replies the clients need to wait the MDS daemons to flush
the journal logs to Rados first. The worst case it will take 5 seconds.

Just trigger to flush the journal logs before waiting.

Fixes: https://tracker.ceph.com/issues/59705
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 2b715b8)
@lxbsz
client: only wait for write MDS OPs when unmounting
12c8685 
We do not care about the read MDS OPs and it's safe by just dropping
them when unmounting.

Fixes: https://tracker.ceph.com/issues/59705
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit ee8443d)
@lxbsz lxbsz requested a review from a team July 4, 2023 01:48
@github-actions github-actions bot added the cephfs Ceph File System label Jul 4, 2023
@github-actions github-actions bot added this to the quincy milestone Jul 4, 2023
@vshankar
Copy link
Contributor

jenkins retest this please

@batrick
Copy link
Member

batrick commented Aug 17, 2023

jenkins test api

@batrick
Copy link
Member

batrick commented Aug 17, 2023

jenkins test make check

batrick
batrick approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Quincy#2023-August-08

@yuriw yuriw merged commit be5c49d into ceph:quincy Aug 17, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System needs-qa wip-yuri5-testing
Projects
None yet
Milestone
quincy
4 participants
@lxbsz @vshankar @batrick @yuriw