Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: move the Inode to new auth mds session when changing auth cap #52335

Merged
merged 2 commits into from Aug 22, 2023
Merged

client: move the Inode to new auth mds session when changing auth cap #52335

merged 2 commits into from Aug 22, 2023

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Jul 6, 2023 •
edited by dparmar18

When the auth cap changes we need to move the Inode to the new session's dirty cap list.

Fixes: https://tracker.ceph.com/issues/56698

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz requested review from rishabh-d-dave and a team July 6, 2023 07:50
@github-actions github-actions bot added the cephfs Ceph File System label Jul 6, 2023
dparmar18
dparmar18 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@dparmar18 dparmar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a crash report patch; it might not be actually solving the issue but would definitely help us identify where does the problem lie.

@vshankar
Copy link
Contributor

https://tracker.ceph.com/issues/56698#note-6

@lxbsz
client: check the xlists in ~MetaSession()
687d4b7 
This will crash the clients more gracefully instead of in ~xlist(),
and this will be easier to debug the root cause and get to know
exactly which list is not empty.

Fixes: https://tracker.ceph.com/issues/56698
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
client: move the Inode to new auth mds session when changing auth cap
8aafa4c 
When the auth cap changes we need to move the Inode to the new session's
dirty cap list.

Fixes: https://tracker.ceph.com/issues/56698
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz lxbsz requested a review from dparmar18 July 19, 2023 03:05
@lxbsz lxbsz changed the title client: check the xlists in ~MetaSession() client: move the Inode to new auth mds session when changing auth cap Jul 19, 2023
dparmar18
dparmar18 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@dparmar18 dparmar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dparmar18
Copy link
Contributor

jenkins test make check

vshankar
vshankar reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vshankar
Copy link
Contributor

vshankar commented Aug 9, 2023

https://pulpito.ceph.com/vshankar-2023-08-09_05:46:29-fs-wip-vshankar-testing-20230809.035933-testing-default-smithi/

@vshankar
Copy link
Contributor

vshankar commented Aug 9, 2023

jenkins test windows

@vshankar
Copy link
Contributor

Test update: Tests passed, preparing run wiki - will merge soon.

vshankar
vshankar approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#22-Aug-2023

@vshankar vshankar merged commit 0af06bd into ceph:main Aug 22, 2023
15 of 18 checks passed
This was referenced Sep 26, 2023
Merged
Closed
Merged
@lxbsz lxbsz mentioned this pull request Oct 12, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshankar vshankar vshankar approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

@rishabh-d-dave rishabh-d-dave Awaiting requested review from rishabh-d-dave

Assignees
No one assigned
Labels
cephfs Ceph File System
Projects
None yet
Milestone
No milestone
3 participants
@lxbsz @vshankar @dparmar18