-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests #52342
Conversation
Whitelisting where I tried didn't work, so trying something else. |
@ljflores any update on this? do ping me in case you need any help |
@dparmar18 none yet, haven't found the right place to whitelist the warning. Still working on it, but if you have any ideas in the meantime, let me know. |
fa92478
to
b2d4012
Compare
Couldn't find a fancy way to whitelist, but this works too. If anyone knows of a better solution, I'm willing to modify it. |
https://github.com/ceph/ceph/blob/main/qa/tasks/mgr/dashboard/helper.py#L271 An API test will wait for 60 secs for the cluster to report healthy; and this laggy OSD warning will not off that easily; seems like we cannot override it with some yaml. I think a better solution here is to turn off the config option |
b2d4012
to
67fb50a
Compare
api test passed. Retriggering one more time for good measure since the failure is somewhat non-deterministic. |
jenkins test api |
67fb50a
to
279562b
Compare
We expect laggy OSDs in this testing environment, so it makes sense to disable this warning. Fixes: https://tracker.ceph.com/issues/61907 Signed-off-by: Laura Flores <lflores@redhat.com>
279562b
to
2322d2c
Compare
merging this now since it'll unblock the test failures. and thank you @ljflores for the fix! |
@dparmar18 please update the tracker if you think this needs to go in to other branches like reef or quincy. |
We expect laggy OSDs in this testing environment,
so it makes sense to whitelist this warning.
Fixes: https://tracker.ceph.com/issues/61907
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows