Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests #52342

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

ljflores
Copy link
Contributor

@ljflores ljflores commented Jul 6, 2023

We expect laggy OSDs in this testing environment,
so it makes sense to whitelist this warning.

Fixes: https://tracker.ceph.com/issues/61907

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the tests label Jul 6, 2023
@batrick
Copy link
Member

batrick commented Jul 6, 2023

https://tracker.ceph.com/issues/61907#note-9

@ljflores
Copy link
Contributor Author

ljflores commented Jul 6, 2023

Whitelisting where I tried didn't work, so trying something else.

@dparmar18
Copy link
Contributor

@ljflores any update on this? do ping me in case you need any help

@ljflores
Copy link
Contributor Author

@dparmar18 none yet, haven't found the right place to whitelist the warning. Still working on it, but if you have any ideas in the meantime, let me know.

@ljflores ljflores force-pushed the wip-whitelist-api branch 3 times, most recently from fa92478 to b2d4012 Compare July 11, 2023 00:25
@ljflores ljflores marked this pull request as ready for review July 11, 2023 02:22
@ljflores
Copy link
Contributor Author

Couldn't find a fancy way to whitelist, but this works too. If anyone knows of a better solution, I'm willing to modify it.

@dparmar18
Copy link
Contributor

Couldn't find a fancy way to whitelist, but this works too. If anyone knows of a better solution, I'm willing to modify it.

https://github.com/ceph/ceph/blob/main/qa/tasks/mgr/dashboard/helper.py#L271

An API test will wait for 60 secs for the cluster to report healthy; and this laggy OSD warning will not off that easily; seems like we cannot override it with some yaml. I think a better solution here is to turn off the config option defer_client_eviction_on_laggy_osds in testing env

@ljflores ljflores changed the title qa/tasks: whitelist "MDS_CLIENTS_LAGGY" in api tests @ljflores qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests Jul 11, 2023
@ljflores ljflores changed the title @ljflores qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests Jul 11, 2023
@ljflores
Copy link
Contributor Author

ljflores commented Jul 11, 2023

api test passed. Retriggering one more time for good measure since the failure is somewhat non-deterministic.

@ljflores
Copy link
Contributor Author

jenkins test api

qa/tasks/ceph_test_case.py Outdated Show resolved Hide resolved
We expect laggy OSDs in this testing environment,
so it makes sense to disable this warning.

Fixes: https://tracker.ceph.com/issues/61907
Signed-off-by: Laura Flores <lflores@redhat.com>
@nizamial09
Copy link
Member

merging this now since it'll unblock the test failures. and thank you @ljflores for the fix!

@nizamial09 nizamial09 merged commit add6bf9 into ceph:main Jul 12, 2023
10 of 11 checks passed
@nizamial09
Copy link
Member

@dparmar18 please update the tracker if you think this needs to go in to other branches like reef or quincy.

@ljflores ljflores deleted the wip-whitelist-api branch July 12, 2023 05:14
@sseshasa
Copy link
Contributor

sseshasa commented Aug 3, 2023

@ljflores This needs to be backported along with #52270. We can include both in a separate QA batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants