reef: mon: block osd pool mksnap for fs pools #52399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 23db15d disabled pool snaps for the rados mksnap path. But ceph osd pool mksnap was an alternate way that pool snaps could be created. This commit disables pool snaps via this alternate path as well. NOTE: Pool-level snaps and fs-level snaps can't co-exist since snap IDs are likely to clash between the two different mechanisms and can result in unintentional data loss when either of the snaps are deleted. Fixes: https://tracker.ceph.com/issues/59552 Signed-off-by: Milind Changire <mchangir@redhat.com> (cherry picked from commit 6203fe1)
Signed-off-by: Milind Changire <mchangir@redhat.com> (cherry picked from commit ab64bfa)
|
@rzarzynski PTAL. (fs suite run is fine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/61959
backport of #51275
parent tracker: https://tracker.ceph.com/issues/59552
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh