-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: add graphs to rgw overview dashboard #52405
mgr/dashboard: add graphs to rgw overview dashboard #52405
Conversation
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
f2d3b41
to
665b4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this chart layout, why not sticking to the new Dashboard v3 Utilization charts style? We already added a new Dashboard pattern, so why not leveraging that style rather than reinventing a new one?
.../frontend/src/app/ceph/dashboard-v3/dashboard-area-chart/dashboard-area-chart.component.html
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/shared/enum/dashboard-promqls.enum.ts
Outdated
Show resolved
Hide resolved
...shboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
Outdated
Show resolved
Hide resolved
...shboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
Outdated
Show resolved
Hide resolved
ee4d59e
to
b9a2509
Compare
jenkins test make check |
2ad0eb9
to
74e0fa8
Compare
74e0fa8
to
8054760
Compare
I did some testing around the PR and here are my findings. I created 20 buckets in default placement and added some data into them.
Visually: Screencast.from.2023-07-31.14-44-23.webm |
8054760
to
00cbb42
Compare
src/pybind/mgr/dashboard/frontend/src/app/shared/api/prometheus.service.ts
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/shared/api/prometheus.service.ts
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/shared/enum/dashboard-promqls.enum.ts
Outdated
Show resolved
Hide resolved
...shboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
Outdated
Show resolved
Hide resolved
...shboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/shared/enum/dashboard-promqls.enum.ts
Outdated
Show resolved
Hide resolved
...shboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/shared/api/prometheus.service.ts
Outdated
Show resolved
Hide resolved
...shboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
Outdated
Show resolved
Hide resolved
de9cac0
to
d37060e
Compare
...board/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.html
Outdated
Show resolved
Hide resolved
jenkins test make check |
...board/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.html
Outdated
Show resolved
Hide resolved
d37060e
to
41d0602
Compare
41d0602
to
64ff0e3
Compare
Signed-off-by: Aashish Sharma <aasharma@redhat.com> (cherry picked from commit a63026348cb4fcb287046c6dc5432d5709d5dff8)
64ff0e3
to
16c27b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Aashish, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thank you @aaSharma14
Fixes: https://tracker.ceph.com/issues/62317
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows