Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: add graphs to rgw overview dashboard #52405

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

aaSharma14
Copy link
Contributor

@aaSharma14 aaSharma14 commented Jul 12, 2023

Screenshot from 2023-07-20 15-26-40

Fixes: https://tracker.ceph.com/issues/62317

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@aaSharma14 aaSharma14 requested a review from a team as a code owner July 12, 2023 07:14
@aaSharma14 aaSharma14 requested review from pereman2 and Pegonzal and removed request for a team July 12, 2023 07:14
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this chart layout, why not sticking to the new Dashboard v3 Utilization charts style? We already added a new Dashboard pattern, so why not leveraging that style rather than reinventing a new one?

@aaSharma14 aaSharma14 force-pushed the rgw-overview-dashboard-graphs branch 4 times, most recently from ee4d59e to b9a2509 Compare July 20, 2023 11:09
@cloudbehl
Copy link
Contributor

jenkins test make check

@aaSharma14 aaSharma14 force-pushed the rgw-overview-dashboard-graphs branch 4 times, most recently from 2ad0eb9 to 74e0fa8 Compare July 25, 2023 06:09
@aaSharma14 aaSharma14 force-pushed the rgw-overview-dashboard-graphs branch from 74e0fa8 to 8054760 Compare July 31, 2023 05:48
@cloudbehl
Copy link
Contributor

cloudbehl commented Jul 31, 2023

I did some testing around the PR and here are my findings.

I created 20 buckets in default placement and added some data into them.

  • Objects data when no bucket should be set to 0 objects rather than not showing it.
  • Should we just consider the data pool for calculating the avg object size. As in my case, the avg size of object was 12KiB but from our calculation its coming 8.6Kib due to consideration of non-data pools like logs, meta ,control and otp.

Visually:
The padding is not consistent between Inventory and Performance stats and performance stats and Used capacity/Avg object size. Double padding on 1rem done on Used capacity/Avg object size cards.

Screencast.from.2023-07-31.14-44-23.webm

@aaSharma14 aaSharma14 force-pushed the rgw-overview-dashboard-graphs branch from 8054760 to 00cbb42 Compare July 31, 2023 11:34
@aaSharma14 aaSharma14 force-pushed the rgw-overview-dashboard-graphs branch 3 times, most recently from de9cac0 to d37060e Compare August 1, 2023 10:39
@cloudbehl
Copy link
Contributor

jenkins test make check

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit a63026348cb4fcb287046c6dc5432d5709d5dff8)
@aaSharma14 aaSharma14 force-pushed the rgw-overview-dashboard-graphs branch from 64ff0e3 to 16c27b3 Compare August 3, 2023 05:45
Copy link
Contributor

@cloudbehl cloudbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aashish, great work!

Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you @aaSharma14

@nizamial09 nizamial09 merged commit 917c3fe into ceph:main Aug 3, 2023
12 of 13 checks passed
@nizamial09 nizamial09 deleted the rgw-overview-dashboard-graphs branch August 3, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants