rgw: Fix potential null dereference in rgw/driver/dbstore/sqlite/statement.cc

[vedanshbhartia]

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[yuvalif]

@vedanshbhartia compilation fails here: https://jenkins.ceph.com/job/ceph-pull-requests/118353/consoleFull#-15211463532a811ea2-3e7b-466b-84b4-d13df7e35809
you probably need to make sure that both true/false options of the ternary expression are of ther same type (std::string?)

[vedanshbhartia]

@vedanshbhartia compilation fails here: https://jenkins.ceph.com/job/ceph-pull-requests/118353/consoleFull#-15211463532a811ea2-3e7b-466b-84b4-d13df7e35809 you probably need to make sure that both true/false options of the ternary expression are of ther same type (std::string?)

sql.get() return a char pointer, but it is defined via a template as follows:

template <typename T>
using sqlite_ptr = std::unique_ptr<T, sqlite_deleter>;

The compiler interprets this as <unresolved overloaded function type> in the ternary operator. Not sure how to fix this.

[yuvalif]

@vedanshbhartia compilation fails here: https://jenkins.ceph.com/job/ceph-pull-requests/118353/consoleFull#-15211463532a811ea2-3e7b-466b-84b4-d13df7e35809 you probably need to make sure that both true/false options of the ternary expression are of ther same type (std::string?)

sql.get() return a char pointer, but it is defined via a template as follows:

template <typename T>
using sqlite_ptr = std::unique_ptr<T, sqlite_deleter>;

The compiler interprets this as <unresolved overloaded function type> in the ternary operator. Not sure how to fix this.

maybe static_cast<char*> would help?

[yuvalif]

@vedanshbhartia did the casting help?

[vedanshbhartia]

@vedanshbhartia did the casting help?

The issue was with the operator precedence. Adding parentheses fixed it

[yuvalif]

teuthology: http://pulpito.ceph.com/yuvalif-2023-10-08_18:12:17-rgw-wip-yuval-test-gsoc-distro-default-smithi/

[yuvalif]

teuthology: http://pulpito.ceph.com/yuvalif-2023-10-08_18:12:17-rgw-wip-yuval-test-gsoc-distro-default-smithi/

same as baseline: https://pulpito.ceph.com/yuriw-2023-10-07_14:02:30-rgw-main-distro-default-smithi/

[yuvalif]

jenkins test windows

[github-actions]

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

[yuvalif]

unstale please

[yuvalif]

test results. see: #52276 (comment)