Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: client: wait rename to finish #52503

Merged
merged 1 commit into from Aug 21, 2023
Merged

quincy: client: wait rename to finish #52503

merged 1 commit into from Aug 21, 2023

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Jul 18, 2023

backport tracker: https://tracker.ceph.com/issues/62010

backport of #40787
parent tracker: https://tracker.ceph.com/issues/49912

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz
client: wait rename to finish
07cd189 
In rare case during the rename if another thread tries to lookup the
dst dentry, it may get an inconsistent result that both src dentry
and dst dentry will link to the same inode at the same time.

Will wait the rename to finish and try it again.

Fixes: https://tracker.ceph.com/issues/49912
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 11fb16d)
@lxbsz lxbsz requested a review from a team July 18, 2023 02:56
@github-actions github-actions bot added the cephfs Ceph File System label Jul 18, 2023
@github-actions github-actions bot added this to the quincy milestone Jul 18, 2023
@vshankar
Copy link
Contributor

jenkins retest this please

@batrick
Copy link
Member

batrick commented Aug 17, 2023

jenkins test make check

@batrick
Copy link
Member

batrick commented Aug 17, 2023

jenkins test api

batrick
batrick approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Quincy#2023-August-08

@yuriw
Copy link
Contributor

yuriw commented Aug 17, 2023

jenkins test make check

@yuriw
Copy link
Contributor

yuriw commented Aug 17, 2023

@lxbsz fell free to merge when all checks passed
ref: https://trello.com/c/ZjPC9CcN

@lxbsz
Copy link
Member Author

lxbsz commented Aug 21, 2023

jenkins test make check

@lxbsz
Copy link
Member Author

lxbsz commented Aug 21, 2023

@lxbsz fell free to merge when all checks passed ref: https://trello.com/c/ZjPC9CcN

Sure, Thanks.

@lxbsz lxbsz merged commit 7482a33 into ceph:quincy Aug 21, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System needs-qa ready-to-merge TESTED
Projects
None yet
Milestone
quincy
4 participants
@lxbsz @vshankar @batrick @yuriw