mds: acquire inode snaplock in open #52520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense that
open("file", O_CREAT|...)
will acquire a readlock on the file's snaplock when the file already
exists, but:
open("file", ...)
will not.
Fixes: https://tracker.ceph.com/issues/62058
Fixes: c1d7f93
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
jenkins retest this please |
|
jenkins test make check arm64 |
|
jenkins test make check arm64 |
|
Test update: Tests passed, preparing run wiki - will merge soon. |
This was referenced Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense that
open("file", O_CREAT|...)
will acquire a readlock on the file's snaplock when the file already exists, but:
open("file", ...)
will not.
Fixes: https://tracker.ceph.com/issues/62058
Fixes: c1d7f93
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows