reef: client: correct quota check in Client::_rename() #52578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client::_rename() only checks for max files quota. As a result, max bytes quota is not enforced. Thus the following code (copied from qa/workunits/fs/quota/quota.sh), runs successfully instead of exiting with error "Disk quota exceeded" - mkdir files limit setfattr limit -n ceph.quota.max_bytes -v 1000 truncate filles/file1 -s 1M mv files limit This patch makes Client::_rename() enforce both kinds of quota which leads command "mv files limit" from above script to fail with "Disk quota exceeded" error. This is the expected behaviour in this case. Introduced-by: dde1a19 Fixes: https://tracker.ceph.com/issues/58220 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit a8d9a25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59410
backport of #50127
parent tracker: https://tracker.ceph.com/issues/58220
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh