mgr/dashboard: cephfs volume rm and rename #52645

avanthakkar · 2023-07-26T07:36:36Z

Fixes: https://tracker.ceph.com/issues/62408
Signed-off-by: avanthakkar avanjohn@gmail.com

Edit CephFS Volume:
Screencast from 2023-07-26 23-51-40.webm

Delete CephFS Volume:
Screencast from 2023-07-26 23-52-46.webm

If mon_allow_pool_delete is disabled:

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

cloudbehl · 2023-07-28T07:15:18Z

Can we divide them in two different PR separating out remove and edit?

avanthakkar · 2023-07-28T09:42:43Z

Can we divide them in two different PR separating out remove and edit?

The changes aren't much for both, it's just right now I've cherry-picked Pere's PR for creation as some changes are required from that PR. Once that PR is merged I can remove that commit so there won't be much changes left then.

nizamial09

Removing the volume gives me this message in notification. this should be handled.

src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-list/cephfs-list.component.ts

src/pybind/mgr/dashboard/frontend/src/app/shared/api/cephfs.service.ts

github-actions · 2023-08-01T11:54:01Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

cloudbehl · 2023-08-03T10:12:03Z

Removing the volume gives me this message in notification. this should be handled.

I can still see this issue.

Also once the notification is gone, I can't see that in task and notification section.

github-actions · 2023-08-03T13:27:09Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

nizamial09 · 2023-08-07T04:02:30Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-list/cephfs-list.component.ts

+    this.modalService.show(FormModalComponent, {
+      titleText: $localize`Edit Volume: ${selectedVolume}`,
+      fields: [
+        {
+          type: 'text',
+          name: 'volumeName',
+          value: selectedVolume,
+          label: $localize`Name`,
+          required: true
+        }
+      ],


I just noticed this. We already have a form component for the volume creation. Why not reuse that and disable whatever that is not needed for the edit? Otherwise whenever we add new things to the creation form, we'll need to explicitly maintain the edit form as well. So we can follow the similar pattern that is done all over the dashboard for this edit form as well.

src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-list/cephfs-list.component.ts

avanthakkar · 2023-08-08T10:42:38Z

jenkins test api

Pegonzal

LGTM! Working nicely, thanks Avan.

avanthakkar · 2023-08-09T11:27:19Z

jenkins retest this please

nizamial09 · 2023-08-09T17:35:42Z

lint:tsc     ] src/app/ceph/cephfs/cephfs-list/cephfs-list.component.spec.ts(11,28): error TS6133: 'modalServiceShow' is declared but its value is never read.
[lint:tsc     ] src/app/ceph/cephfs/cephfs-list/cephfs-list.component.spec.ts(15,1): error TS6133: 'NotificationType' is declared but its value is never read.
[lint:tsc     ] src/app/ceph/cephfs/cephfs-list/cephfs-list.component.spec.ts(16,1): error TS6133: 'NotificationService' is declared but its value is never read.
[lint:tsc     ] src/app/ceph/cephfs/cephfs-list/cephfs-list.component.spec.ts(18,1): error TS6133: 'FormModalComponent' is declared but its value is never read.

Try running 'npm run fix' to fix some linting errors. Some errors might need a manual fix.

Lint failing on relates errors @avanthakkar . Looks like some unused variables. Try to run npm run fix before committing

nizamial09 · 2023-08-09T17:36:21Z

2023-08-09 15:17:08,368.368 INFO:__main__:
2023-08-09 15:17:08,368.368 INFO:__main__:----------------------------------------------------------------------
2023-08-09 15:17:08,368.368 INFO:__main__:Traceback (most recent call last):
2023-08-09 15:17:08,368.368 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/test_cephfs.py", line 181, in test_cephfs_remove
2023-08-09 15:17:08,368.368 INFO:__main__:    self.assertStatus(200)
2023-08-09 15:17:08,368.368 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py", line 497, in assertStatus
2023-08-09 15:17:08,368.368 INFO:__main__:    self.assertEqual(self._resp.status_code, status)
2023-08-09 15:17:08,368.368 INFO:__main__:AssertionError: 400 != 200
2023-08-09 15:17:08,368.368 INFO:__main__:
Cannot find device "ceph-brx"
2023-08-09 15:17:08,387.387 INFO:__main__:
2023-08-09 15:17:08,387.387 INFO:__main__:----------------------------------------------------------------------
2023-08-09 15:17:08,387.387 INFO:__main__:

Api test failure is also related!

avanthakkar · 2023-08-10T12:05:56Z

jenkins retest this please

github-actions · 2023-08-10T16:35:43Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

nizamial09 · 2023-08-11T04:24:24Z

2023-08-11 04:17:49,409.409 INFO:__main__:----------------------------------------------------------------------
2023-08-11 04:17:49,409.409 INFO:__main__:
2023-08-11 04:17:49,409.409 INFO:__main__:Traceback (most recent call last):
2023-08-11 04:17:49,409.409 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/test_cephfs.py", line 177, in test_cephfs_create
2023-08-11 04:17:49,409.409 INFO:__main__:    self.assertStatus(200)
2023-08-11 04:17:49,410.410 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py", line 497, in assertStatus
2023-08-11 04:17:49,410.410 INFO:__main__:    self.assertEqual(self._resp.status_code, status)
2023-08-11 04:17:49,410.410 INFO:__main__:AssertionError: 201 != 200
2023-08-11 04:17:49,410.410 INFO:__main__:
Cannot find device "ceph-brx"
2023-08-11 04:17:49,429.429 INFO:__main__:
2023-08-11 04:17:49,429.429 INFO:__main__:----------------------------------------------------------------------
2023-08-11 04:17:49,430.430 INFO:__main__:

nizamial09 · 2023-08-11T04:24:59Z

@avanthakkar maybe its best to test the API tests of this PR locally before pushing and waiting for the jenkins to pass.

nizamial09 · 2023-08-11T04:25:29Z

also I just noticed there is no tracker attached!

avanthakkar · 2023-08-11T12:08:08Z

jenkins test api

avanthakkar · 2023-08-11T12:13:15Z

jenkins test make check

cloudbehl · 2023-08-11T12:58:15Z

jenkins test make check

Fixes: https://tracker.ceph.com/issues/62408 Signed-off-by: avanthakkar <avanjohn@gmail.com>

github-actions bot added api-change dashboard pybind tests labels Jul 26, 2023

avanthakkar changed the title ~~mgr/dashboard: cephfs volume rm and rename REST APIs~~ mgr/dashboard: cephfs volume rm and rename Jul 26, 2023

avanthakkar force-pushed the cephfs-vol-rm branch from 848cc9b to 0dacf60 Compare August 1, 2023 08:06

avanthakkar marked this pull request as ready for review August 1, 2023 08:06

avanthakkar requested a review from a team as a code owner August 1, 2023 08:06

avanthakkar requested review from aaSharma14 and nizamial09 and removed request for a team August 1, 2023 08:06

avanthakkar added wip-athakkar-testing DNM and removed wip-athakkar-testing DNM labels Aug 1, 2023

nizamial09 reviewed Aug 1, 2023

View reviewed changes

github-actions bot added the needs-rebase label Aug 1, 2023

avanthakkar force-pushed the cephfs-vol-rm branch from 0dacf60 to aed41c2 Compare August 2, 2023 17:34

github-actions bot removed the needs-rebase label Aug 2, 2023

github-actions bot added the needs-rebase label Aug 3, 2023

nizamial09 requested changes Aug 7, 2023

View reviewed changes

avanthakkar marked this pull request as draft August 7, 2023 06:41

avanthakkar force-pushed the cephfs-vol-rm branch 2 times, most recently from e7ae4df to 1b70344 Compare August 7, 2023 09:28

github-actions bot removed the needs-rebase label Aug 7, 2023

avanthakkar force-pushed the cephfs-vol-rm branch from 9ec3221 to a815920 Compare August 9, 2023 09:38

Pegonzal approved these changes Aug 9, 2023

View reviewed changes

avanthakkar force-pushed the cephfs-vol-rm branch 2 times, most recently from fbe0f63 to 860cae5 Compare August 10, 2023 10:41

avanthakkar force-pushed the cephfs-vol-rm branch from 860cae5 to ca6590c Compare August 10, 2023 14:26

github-actions bot added the needs-rebase label Aug 10, 2023

avanthakkar force-pushed the cephfs-vol-rm branch from ca6590c to 9cbca57 Compare August 10, 2023 16:47

github-actions bot removed the needs-rebase label Aug 10, 2023

nizamial09 mentioned this pull request Aug 10, 2023

mgr/dashboard: provide ability to edit cephfs subvolume #52861

Merged

14 tasks

avanthakkar force-pushed the cephfs-vol-rm branch from 9cbca57 to f7779d8 Compare August 10, 2023 20:22

avanthakkar force-pushed the cephfs-vol-rm branch 3 times, most recently from d6504f3 to a540cac Compare August 11, 2023 09:30

mgr/dashboard: cephfs volume rm and rename

d756fad

Fixes: https://tracker.ceph.com/issues/62408 Signed-off-by: avanthakkar <avanjohn@gmail.com>

avanthakkar force-pushed the cephfs-vol-rm branch from a540cac to d756fad Compare August 11, 2023 16:55

nizamial09 merged commit 91f75ab into ceph:main Aug 11, 2023
11 of 13 checks passed

nizamial09 deleted the cephfs-vol-rm branch August 11, 2023 18:53

nizamial09 mentioned this pull request Aug 16, 2023

reef: mgr/dashboard: cephfs volume rm and rename #53026

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard: cephfs volume rm and rename #52645

mgr/dashboard: cephfs volume rm and rename #52645

avanthakkar commented Jul 26, 2023 •

edited

cloudbehl commented Jul 28, 2023

avanthakkar commented Jul 28, 2023

nizamial09 left a comment

github-actions bot commented Aug 1, 2023

cloudbehl commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

nizamial09 Aug 7, 2023

avanthakkar commented Aug 8, 2023

Pegonzal left a comment

avanthakkar commented Aug 9, 2023

nizamial09 commented Aug 9, 2023

nizamial09 commented Aug 9, 2023

avanthakkar commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

nizamial09 commented Aug 11, 2023

nizamial09 commented Aug 11, 2023

nizamial09 commented Aug 11, 2023

avanthakkar commented Aug 11, 2023

avanthakkar commented Aug 11, 2023

cloudbehl commented Aug 11, 2023

mgr/dashboard: cephfs volume rm and rename #52645

mgr/dashboard: cephfs volume rm and rename #52645

Conversation

avanthakkar commented Jul 26, 2023 • edited

Contribution Guidelines

Checklist

cloudbehl commented Jul 28, 2023

avanthakkar commented Jul 28, 2023

nizamial09 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 1, 2023

cloudbehl commented Aug 3, 2023

github-actions bot commented Aug 3, 2023

nizamial09 Aug 7, 2023

Choose a reason for hiding this comment

avanthakkar commented Aug 8, 2023

Pegonzal left a comment

Choose a reason for hiding this comment

avanthakkar commented Aug 9, 2023

nizamial09 commented Aug 9, 2023

nizamial09 commented Aug 9, 2023

avanthakkar commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

nizamial09 commented Aug 11, 2023

nizamial09 commented Aug 11, 2023

nizamial09 commented Aug 11, 2023

avanthakkar commented Aug 11, 2023

avanthakkar commented Aug 11, 2023

cloudbehl commented Aug 11, 2023

avanthakkar commented Jul 26, 2023 •

edited