Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/cephfs: fix test_disallow_monitor_managed_snaps_for_fs_pools #52709

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

rishabh-d-dave
Copy link
Contributor

run_cluster_cmd() method is not available anymore because it was deleted
here on this PR -
https://github.com/ceph/ceph/pull/50569/files#diff-1c6c246ba42f343603d7174198dd1fb9c2654b6c883594d1a0891096b7a35875L408

Fixes: https://tracker.ceph.com/issues/62243

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

run_cluster_cmd() method is not available anymore because it was deleted
here on this PR -
https://github.com/ceph/ceph/pull/50569/files#diff-1c6c246ba42f343603d7174198dd1fb9c2654b6c883594d1a0891096b7a35875L408

Fixes: https://tracker.ceph.com/issues/62243
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@vshankar
Copy link
Contributor

vshankar commented Aug 1, 2023

jenkins retest this please

@rishabh-d-dave
Copy link
Contributor Author

@vshankar
Copy link
Contributor

vshankar commented Aug 2, 2023

@rishabh-d-dave I guess this is ready to merge?

@rishabh-d-dave
Copy link
Contributor Author

@vshankar Yes. This PR is ready for merge now since the test ran successfully and test_disallow_monitor_managed_snaps_for_fs_pools is passing now successfully -

2023-08-02T12:48:45.352 INFO:teuthology.orchestra.run.smithi026.stderr:2023-08-02T12:48:45.345+0000 7f9e57693640  1 -- 172.21.15.26:0/563920022 shutdown_connections
2023-08-02T12:48:45.352 INFO:teuthology.orchestra.run.smithi026.stderr:2023-08-02T12:48:45.345+0000 7f9e57693640  1 -- 172.21.15.26:0/563920022 wait complete.
2023-08-02T12:48:45.370 INFO:tasks.cephfs_test_runner:test_disallow_monitor_managed_snaps_for_fs_pools (tasks.cephfs.test_snapshots.TestMonSnapsAndFsPools) ... ok

@rishabh-d-dave rishabh-d-dave merged commit 0584cd3 into ceph:main Aug 2, 2023
11 of 12 checks passed
@rishabh-d-dave rishabh-d-dave deleted the cephfs-test_snapshots branch August 2, 2023 13:48
@rishabh-d-dave
Copy link
Contributor Author

Just for record: this bug fixed on this PR was introduced on PR #50569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix cephfs Ceph File System tests wip-rishabh-testing Rishabh's testing label
Projects
None yet
3 participants