Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reef: qa/standalone/osd/divergent-prior.sh: Divergent test 3 with pg_autoscale_mode on pick divergent osd #52721

Merged
merged 1 commit into from Oct 9, 2023
Merged

reef: qa/standalone/osd/divergent-prior.sh: Divergent test 3 with pg_autoscale_mode on pick divergent osd #52721

merged 1 commit into from Oct 9, 2023

Conversation

NitzanMordhai
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/62251

backport of #51909
parent tracker: https://tracker.ceph.com/issues/56034

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@NitzanMordhai
test: Divergent test 3 with pg_autoscale_mode on pick divergent osd
ea4f32a 
When creating new pool, the current code pick the divergent osd by
the first pg out of pg dump pgs, that can be in "unknown" status
which means the up_primary = -1 and that will fail the test.
We need to wait unitl the first pg is active+clean

Fixes: https://tracker.ceph.com/issues/56034
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 13c640b)
@NitzanMordhai NitzanMordhai requested a review from a team as a code owner August 1, 2023 05:12
@NitzanMordhai NitzanMordhai added this to the reef milestone Aug 1, 2023
@github-actions github-actions bot added the core label Aug 1, 2023
@kamoltat
Copy link
Member

kamoltat commented Sep 7, 2023

jenkins test make check

@kamoltat
Copy link
Member

kamoltat commented Sep 7, 2023

jenkins test api

@kamoltat
Copy link
Member

kamoltat commented Sep 7, 2023 •
edited

@NitzanMordhai So I think how usually format the PR description for backports is by keeping the original description and then write something like:

Back porting relevant commits from main PR:
https://github.com/ceph/ceph/pull/51909

so for you, your PR description should look like:

When creating new pool, the current code pick the divergent osd by the first pg out of pg dump pgs, that can be in "unknown" status which means the up_primary = -1 and that will fail the test. We need to wait unitl the first pg is active+clean

Fixes: https://tracker.ceph.com/issues/56034

Back porting relevant commits from main PR:
https://github.com/ceph/ceph/pull/51909

backport tracker: https://tracker.ceph.com/issues/62251

@kamoltat
Copy link
Member

kamoltat commented Sep 7, 2023

hmm but i can see that you used a script for backporting so I guess you're fine

kamoltat
kamoltat approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NitzanMordhai
Copy link
Contributor Author

hmm but i can see that you used a script for backporting so I guess you're fine

@kamoltat yes, i used the backport script, thanks for reviewing!

@yuriw yuriw merged commit ee9edee into ceph:reef Oct 9, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamoltat kamoltat kamoltat approved these changes

Assignees
No one assigned
Labels
core needs-qa tests wip-yuri7-testing
Projects
None yet
Milestone
reef
3 participants
@NitzanMordhai @kamoltat @yuriw