pacific: mds: Fix the linkmerge assert check #52726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's say there is a hardlink created as below. touch file1 ln file1 hl_file1 In this case 'file1' holds the primary inode and 'hl_file' holds the remote inode (holds primary inode number and other required info). Now, if the 'file1' is deleted first, it's moved to a stray directory and can't be deleted because the hardlink 'hl_file1' still exists which requires primary inode. So on straydn eval, this primary inode is linked to 'hl_file1 and remote inode is removed. This is called the linkmerge/stray reintegration. So in the linkmerge case, the srcdnl is primary straydn and the destdnl is the remote. Signed-off-by: Kotresh HR <khiremat@redhat.com> Fixes: https://tracker.ceph.com/issues/61879 (cherry picked from commit 85279ac)
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/62242
backport of #51934
parent tracker: https://tracker.ceph.com/issues/61879
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh