Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: rgw: swift : check for valid key in POST forms #52729

Merged
merged 1 commit into from Nov 15, 2023
Merged

pacific: rgw: swift : check for valid key in POST forms #52729

merged 1 commit into from Nov 15, 2023

Conversation

theanalyst
Copy link
Member

https://tracker.ceph.com/issues/58817

Modified rgw::sal changes to be in line with pacific

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@theanalyst
rgw: swift : check for valid key in POST forms
39356ff 
Avoid processing key based info if the POST form didn't contain a key

Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@cern.ch>
(cherry picked from commit 4be2fce)
modified changes to be compatible with pacific's rgw_sal version
@github-actions github-actions bot added the rgw label Aug 1, 2023
@github-actions github-actions bot added this to the pacific milestone Aug 1, 2023
@cbodley
Copy link
Contributor

cbodley commented Aug 1, 2023

thanks @theanalyst! would you please create the quincy backport for https://tracker.ceph.com/issues/58818 as well?

@theanalyst
Copy link
Member Author

thanks @theanalyst! would you please create the quincy backport for https://tracker.ceph.com/issues/58818 as well?

sure doing

@theanalyst
Copy link
Member Author

thanks @theanalyst! would you please create the quincy backport for https://tracker.ceph.com/issues/58818 as well?

created #52739

@ljflores
Copy link
Contributor

jenkins test make check

@ljflores
Copy link
Contributor

jenkins test api

@ljflores
Copy link
Contributor

Rados approved: https://tracker.ceph.com/projects/rados/wiki/PACIFIC#httpstrellocomcQIYioTlt1818-wip-yuri3-testing-2023-08-01-0825-pacific

@yuriw
Copy link
Contributor

yuriw commented Aug 11, 2023

Per @smanjara "the tempest tests are failing for some other reason and this pr #52729 depends on running them successfully. Ali is looking into it. For now please remove the pr from this batch."

ref: https://trello.com/c/QIYioTlt

@theanalyst @alimaredia pls merge if it's ready or mark for retest

@cfsnyder cfsnyder modified the milestones: pacific, v16.2.15 Nov 13, 2023
@yuriw yuriw merged commit df905b9 into ceph:pacific Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

@dang dang

@cbodley cbodley

@yuriw yuriw

Labels
needs-qa rgw wip-yuri6-testing
Projects
None yet
Milestone
v16.2.15
6 participants
@theanalyst @cbodley @ljflores @yuriw @dang @cfsnyder