Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mds: adjust pre_segments_size for MDLog when trimming segments for st… #52755

Merged
merged 1 commit into from Sep 19, 2023
Merged

mds: adjust pre_segments_size for MDLog when trimming segments for st… #52755

merged 1 commit into from Sep 19, 2023

Conversation

vshankar
Copy link
Contributor

@vshankar vshankar commented Aug 2, 2023 •
edited by joscollin

…andby-replay

Otherwise, trimming mdlog during shutdown can result in the number of segments lagging pre_segments_size (the number of segments processed during replay).

Fixes: http://tracker.ceph.com/issues/59833

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@vshankar
mds: adjust pre_segments_size for MDLog when trimming segments for st…
bd784ee 
…andby-replay

Otherwise, trimming mdlog during shutdown can result in the number of
segments lagging pre_segments_size (the number of segments processed
during replay).

Fixes: http://tracker.ceph.com/issues/59833
Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar vshankar added the cephfs Ceph File System label Aug 2, 2023
@vshankar vshankar requested a review from a team August 2, 2023 07:18
joscollin
joscollin approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is good.

@joscollin
Copy link
Member

jenkins test make check arm64

@vshankar
Copy link
Contributor Author

vshankar commented Sep 5, 2023

@mchangir Anything that's blocking merging this? How did the run go?

@mchangir mchangir merged commit 7f0df59 into ceph:main Sep 19, 2023
12 of 16 checks passed
@mchangir
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/mchangir-2023-09-12_05:40:22-fs-wip-mchangir-testing-20230908.140927-testing-default-smithi/

This was referenced Oct 16, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

@joscollin joscollin joscollin approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System
Projects
None yet
Milestone
No milestone
4 participants
@vshankar @joscollin @mchangir @batrick