Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs-shell: modify and add descriptions for commands #52756

Closed
wants to merge 0 commits into from

Conversation

tengjie5
Copy link
Contributor

@tengjie5 tengjie5 commented Aug 2, 2023

Fixes: https://tracker.ceph.com/issues/62074
Signed-off-by: jie teng tengjie5@asiainfo.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the cephfs Ceph File System label Aug 2, 2023
@vshankar
Copy link
Contributor

vshankar commented Aug 3, 2023

@neesingh-rh PTAL

Copy link
Contributor

@neesingh-rh neesingh-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are taking care of descriptions, I guess complete_mv also need modification.

@neesingh-rh neesingh-rh changed the title cephfs-shell: modify and add descriptions for three cmds cephfs-shell: modify and add descriptions for commands Aug 3, 2023
@tengjie5
Copy link
Contributor Author

tengjie5 commented Aug 3, 2023

@neesingh-rh hi,description of mv has modified,please review again.

@neesingh-rh
Copy link
Contributor

Pls combine the change in single commit, no need to have a new one for suggested change.

@neesingh-rh
Copy link
Contributor

make check is failing for :

py3: install_deps /home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/cephfs/shell> python -I -m pip install flake8
py3: freeze /home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/cephfs/shell> python -m pip freeze --all
py3: flake8==6.1.0,mccabe==0.7.0,pip==22.3.1,pycodestyle==2.11.0,pyflakes==3.1.0,setuptools==65.6.3,wheel==0.38.4
py3: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/cephfs/shell> flake8 --ignore=W503 --max-line-length=100 cephfs-shell
cephfs-shell:1125:101: E501 line too long (120 > 100 characters)
py3: exit 1 (1.09 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/cephfs/shell> flake8 --ignore=W503 --max-line-length=100 cephfs-shell pid=436003
  py3: FAIL code 1 (10.59=setup[9.50]+cmd[1.09] seconds)
  evaluation failed :( (10.88 seconds)

@neesingh-rh
Copy link
Contributor

Your commit(s) misses Signed-off-by, Pls add.

@dparmar18
Copy link
Contributor

and please remove the redundant commits

@@ -1122,7 +1122,7 @@ class CephFSShell(Cmd):
"""
return self.complete_filenames(text, line, begidx, endidx)

mv_parser = argparse.ArgumentParser(description='Move File.')
mv_parser = argparse.ArgumentParser(description='Rename a file or Move a file from source path to the destination.')
Copy link
Contributor

@dparmar18 dparmar18 Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break this line into two to fix the #52756 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System
Projects
None yet
4 participants