New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephfs-shell: modify and add descriptions for commands #52756
Conversation
@neesingh-rh PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are taking care of descriptions, I guess complete_mv
also need modification.
@neesingh-rh hi,description of mv has modified,please review again. |
Pls combine the change in single commit, no need to have a new one for suggested change. |
make check is failing for :
|
Your commit(s) misses Signed-off-by, Pls add. |
and please remove the redundant commits |
src/tools/cephfs/shell/cephfs-shell
Outdated
@@ -1122,7 +1122,7 @@ class CephFSShell(Cmd): | |||
""" | |||
return self.complete_filenames(text, line, begidx, endidx) | |||
|
|||
mv_parser = argparse.ArgumentParser(description='Move File.') | |||
mv_parser = argparse.ArgumentParser(description='Rename a file or Move a file from source path to the destination.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break this line into two to fix the #52756 (comment)
eff7ec1
to
901480a
Compare
Fixes: https://tracker.ceph.com/issues/62074
Signed-off-by: jie teng tengjie5@asiainfo.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows