New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reef: mgr/dashboard: empty grafana panels for performance of daemons #52774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/61792 Signed-off-by: avanthakkar <avanjohn@gmail.com> Removing the `ceph-` prefix from ceph_daemon label to adopt it with the label format used by queries in grafana dashboards. Also changing the `instance_id` label for rgw to match the values coming from exporter and prometheus module (cherry picked from commit fa2d1f9)
avanthakkar
requested review from
cloudbehl and
Pegonzal
and removed request for
a team
August 2, 2023 20:07
Signed-off-by: avanthakkar <avanjohn@gmail.com> (cherry picked from commit ca56918)
jmolmo
approved these changes
Aug 3, 2023
jenkins test dashboard cephadm |
jenkins test windows |
jenkins test dashboard |
jenkins test dashboard cephadm |
Fixes: https://tracker.ceph.com/issues/58164 Signed-off-by: Avan Thakkar <athakkar@redhat.com> Introducing module option in prometheus module to enable/disable support for exporting ceph daemons perf counters as prometheus metrics, by default this option will be disabled. The use case for this option is in case if ceph-exporter deployment failed for any reason then user still can have option to fetch metrics from promethues exporter.
There's a missing backport which was failing the e2e. I included this backport in this PR itself for tracker https://tracker.ceph.com/issues/59317 |
jenkins test dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: no-conflicts
Backport without conflicts
build/ops
dashboard
documentation
mgr
monitoring
pybind
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/62223
backport of #52191, #49248
parent trackers: https://tracker.ceph.com/issues/61792, #52774
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh