Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: cephfs subvolume creation form #52786

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Aug 3, 2023

Fixes: https://tracker.ceph.com/issues/62345

scrnli_8_4_2023_4-09-13.PM.mp4

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@nizamial09 nizamial09 changed the title mgr/dashboard: cephfs subvolume list mgr/dashboard: cephfs subvolume creation form Aug 3, 2023
@nizamial09 nizamial09 marked this pull request as ready for review August 7, 2023 08:04
@nizamial09 nizamial09 requested a review from a team as a code owner August 7, 2023 08:04
@nizamial09 nizamial09 requested review from cloudbehl, avanthakkar, pereman2 and Pegonzal and removed request for a team August 7, 2023 08:04
Copy link
Contributor

@pereman2 pereman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo but lgtm

src/pybind/mgr/dashboard/controllers/cephfs.py Outdated Show resolved Hide resolved
@cloudbehl
Copy link
Contributor

Amazing work! Thanks Nizam!

Tested this and LGTM.
image

@nizamial09 nizamial09 merged commit 4db3c63 into ceph:main Aug 8, 2023
11 of 14 checks passed
@nizamial09 nizamial09 deleted the fs-subvolumes-create branch August 8, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants