quincy: rgw: fetch_remote_obj() preserves original part lengths for BlockDecrypt #52818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users now call a static read_manifest_parts() function, and pass the resulting vector into the BlockDecrypt constructor Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit d8a82f5) Conflicts: no null_yield argument src/rgw/rgw_crypt.cc src/rgw/rgw_crypt.h src/rgw/rgw_rest_s3.cc src/test/rgw/test_rgw_crypto.cc
because multisite replicates multipart objects as a single part, we lose information about the part sizes from the original manifest that is necessary to correctly decrypt across those part boundaries on replication, parse the part lengths out of the source object's manifest, and store them in a separate RGW_ATTR_CRYPT_PARTS for use on decryption Fixes: https://tracker.ceph.com/issues/46062 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit e7d98fb)
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 902d074)
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 07d28ba)
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 237fa27) Conflicts: missing change for PutACL mtime src/rgw/rgw_rados.cc
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit e90bfba) Conflicts: src/rgw/rgw_admin.cc missing 'bucket shard' commands, driver->store src/rgw/rgw_rados.cc const rgw_obj, get_obj_state manifest arg
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 61cf6ee)
smanjara
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/62321
backport of #52248
parent tracker: https://tracker.ceph.com/issues/46062
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh