mount.fuse.ceph: strip the 'nofail' option from those that fuse will see #52834
Conversation
Signed-off-by: Leonid Usov <leonid.usov@ibm.com> Fixes: https://tracker.ceph.com/issues/58394
|
@ceph/cephfs |
| # - nofail option is also not recognized by libfuse. | ||
| # Starting with fuse 3.2.2 the option is also ignored by mount.fuse, see | ||
| # https://github.com/libfuse/libfuse/commit/a83cd72f641671b71b8268b1765e449cae071f3e | ||
| strip_opts = ['defaults', 'noauto', '_netdev', 'nofail'] |
There was a problem hiding this comment.
I think this approach is correct. Just one question - In the redmine tracker you put
I'll submit a patch that does the same on our side, for versions of fuse < 3.2.2
So, I expected to see some form for version check somewhere. What am I missing?
There was a problem hiding this comment.
I should add comment or edit that message on the tracker. The thing is, when implementing this, I realized that I should not be checking the version as the fix from the library is only affecting users of their supplied mount.fuse helper. In our case, we won't be calling through their mount helper, we are using our own. As a result, the correct approach should be filtering this option unconditionally.
There was a problem hiding this comment.
Makes sense. Thx for explaining.
|
Integration branch - https://shaman.ceph.com/builds/ceph/wip-vshankar-testing-20230808.093601/ Test runs in ~3 hrs. |
|
@vshankar do I understand correctly that this has passed the tests? What else is needed before we can merge? |
Still under testing - https://pulpito.ceph.com/?branch=wip-vshankar-testing-20230808.093601 |
Fixes: https://tracker.ceph.com/issues/58394
The research of this problem has shown that stripping the option from the list that is sent to libfuse is the correct approach.
libfuse themselves took this route in libfuse/libfuse@a83cd72.
The kernel mainly uses the option to decide how to treat errors during the boot process or mount -a. While I can't say whether some file systems overload this option with internal functionality, it's not used by the libfuse.
More info:
#26992
systemd/systemd#5032
https://access.redhat.com/discussions/4976921
https://furorteutonicus.eu/2013-08-29-nofail-and-nobootwait-mount-options-in-fstab-prevent-boot-problems
OpenMediaVault-Plugin-Developers/openmediavault-unionfilesystems#36
https://linux.die.net/man/8/mount
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows