Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/ceph_monstore_tool: additional commands and doc #52855

Merged
merged 4 commits into from
Nov 13, 2023
Merged

tools/ceph_monstore_tool: additional commands and doc #52855

merged 4 commits into from
Nov 13, 2023

Conversation

Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Aug 7, 2023 •
edited

Added:

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Matan-B Matan-B requested review from a team as code owners August 7, 2023 07:08
@zdover23
Copy link
Contributor

zdover23 commented Aug 7, 2023

@Matan-B: I can't approve PRs that contain code changes, but if you separate out the docs updates from the code changes and raise a PR that contains only these docs changes, I can fix the docs so that they can pass the build check.

NitzanMordhai
NitzanMordhai requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@NitzanMordhai NitzanMordhai left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to return the ret from clear_key? Isn't it more informative than 1 ?

@Matan-B Matan-B force-pushed the wip-matanb-monstore-osd_snap branch from 6c7fc76 to 0f85b38 Compare August 7, 2023 12:36
@Matan-B Matan-B requested review from NitzanMordhai and a team and removed request for a team August 7, 2023 12:40
@Matan-B Matan-B mentioned this pull request Aug 7, 2023
Merged
14 tasks
@rzarzynski rzarzynski self-requested a review August 7, 2023 14:55
NitzanMordhai
NitzanMordhai approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@NitzanMordhai NitzanMordhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matan-B Matan-B requested a review from batrick August 22, 2023 12:51
@Matan-B
Copy link
Contributor Author

Matan-B commented Aug 22, 2023

@batrick Does this PR require qa or is it good to go?

@batrick
Copy link
Member

batrick commented Sep 1, 2023

@batrick Does this PR require qa or is it good to go?

Yes, it requires QA. I'm not the mon maintainer though. Run it by core folks.

idryomov
idryomov reviewed Sep 18, 2023
View reviewed changes
src/mon/MonitorDBStore.h Outdated Show resolved Hide resolved
src/tools/ceph_monstore_tool.cc Outdated Show resolved Hide resolved
src/tools/ceph_monstore_tool.cc Outdated Show resolved Hide resolved
src/tools/ceph_monstore_tool.cc Outdated Show resolved Hide resolved
src/tools/ceph_monstore_tool.cc Outdated Show resolved Hide resolved
@Matan-B Matan-B removed the needs-qa label Sep 19, 2023
@Matan-B
tools/ceph_monstore_tool: add ceph-specific option example
6caf2c4 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-monstore-osd_snap branch from 0f85b38 to 644a82f Compare October 9, 2023 13:22
@Matan-B Matan-B requested a review from idryomov October 9, 2023 13:24
@Matan-B Matan-B force-pushed the wip-matanb-monstore-osd_snap branch from 644a82f to 8e6bbb3 Compare October 9, 2023 13:44
@Matan-B
tools/ceph_monstore_tool: add get-key command
23c7d1e 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
tools/ceph_monstore_tool: add remove-key command
cfd2cc9 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
doc/man/8/ceph-monstore-tool.rst: doc fixes
42f94dd 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-monstore-osd_snap branch from 8e6bbb3 to 42f94dd Compare October 9, 2023 13:47
@pdvian
Copy link

pdvian commented Nov 9, 2023

RADOS approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpspulpitocephcomyuriw-2023-10-24_001103-rados-wip-yuri2-testing-2023-10-23-0917-distro-default-smithi

@yuriw yuriw merged commit c2d216b into ceph:main Nov 13, 2023
10 of 11 checks passed
@zdover23
Copy link
Contributor

@yuriw: Can the docs-related parts of this PR be backported to both Reef and Quincy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyeleven anthonyeleven anthonyeleven left review comments

@NitzanMordhai NitzanMordhai NitzanMordhai approved these changes

@rzarzynski rzarzynski Awaiting requested review from rzarzynski

@batrick batrick Awaiting requested review from batrick

@idryomov idryomov Awaiting requested review from idryomov

Assignees
No one assigned
Labels
core documentation mon needs-qa wip-yuri2-testing
Projects
None yet
Milestone
No milestone
9 participants
@Matan-B @zdover23 @batrick @pdvian @idryomov @anthonyeleven @NitzanMordhai @yuriw @ljflores