-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: cephfs subvolume remove #52869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR, looks good to me.
Nit: Change the Delete button to call it Remove.
Screencast.from.2023-08-08.13-13-40.webm
c4fc3e2
to
c550f20
Compare
Thanks @cloudbehl! Done |
c550f20
to
76d7a6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well!
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
76d7a6e
to
f916d25
Compare
jenkins test dashboard |
f916d25
to
cc281e7
Compare
Fixes: https://tracker.ceph.com/issues/62349 Signed-off-by: Nizamudeen A <nia@redhat.com>
cc281e7
to
3d53395
Compare
Fixes: https://tracker.ceph.com/issues/62349
scrnli_8_8_2023_10-40-19.AM.mp4
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows