Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: cephfs subvolume remove #52869

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Aug 8, 2023

Fixes: https://tracker.ceph.com/issues/62349

scrnli_8_8_2023_10-40-19.AM.mp4

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@nizamial09 nizamial09 requested a review from a team as a code owner August 8, 2023 04:58
@nizamial09 nizamial09 requested review from cloudbehl and Pegonzal and removed request for a team August 8, 2023 04:58
Copy link
Contributor

@cloudbehl cloudbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR, looks good to me.

Nit: Change the Delete button to call it Remove.

Screencast.from.2023-08-08.13-13-40.webm

@nizamial09
Copy link
Member Author

Change the Delete button to call it Remove.

Thanks @cloudbehl! Done

Copy link
Contributor

@Pegonzal Pegonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@aaSharma14
Copy link
Contributor

jenkins test dashboard

Fixes: https://tracker.ceph.com/issues/62349
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09 nizamial09 merged commit 4a78079 into ceph:main Aug 14, 2023
10 of 13 checks passed
@nizamial09 nizamial09 deleted the fs-subvolumes-rm branch August 14, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants