Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: mgr: store names of modules that register RADOS clients in the MgrMap #52883

Merged
merged 2 commits into from Aug 21, 2023

Conversation

ajarr
Copy link
Contributor

@ajarr ajarr commented Aug 8, 2023

backport tracker: https://tracker.ceph.com/issues/59737


backport of #50065
parent tracker: https://tracker.ceph.com/issues/58691

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

The MgrMap stores a list of RADOS clients' addresses registered by the
mgr modules. During failover of ceph-mgr, the list is used to blocklist
clients belonging to the failed ceph-mgr.

Store the names of the mgr modules that registered the RADOS clients
along with the clients' addresses in the MgrMap. During debugging, this
allows easy identification of the mgr module that registered a
particular RADOS client by just dumping the MgrMap (`ceph mgr dump`).

Following is the MgrMap output with a module's client name displayed
along with its client addrvec,
$ ceph mgr dump | jq '.active_clients[0]'
{
  "name": "devicehealth",
  "addrvec": [
    {
      "type": "v2",
      "addr": "10.0.0.148:0",
      "nonce": 612376578
    }
  ]
}

Fixes: https://tracker.ceph.com/issues/58691
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit b545fb9)

Conflicts:
	PendingReleaseNotes [ moved to >=16.2.14 section ]
... that modify and access the data member 'clients' respectively.

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit a586dcc)
@ajarr ajarr requested a review from a team as a code owner August 8, 2023 18:23
@ajarr ajarr added this to the pacific milestone Aug 8, 2023
@ajarr ajarr added the core label Aug 8, 2023
@ajarr ajarr requested a review from idryomov August 8, 2023 18:26
@ajarr ajarr added the needs-qa label Aug 8, 2023
@yuriw yuriw merged commit 38ffa5f into ceph:pacific Aug 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants