Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: create subvolume groups #52886

Merged
merged 1 commit into from
Aug 10, 2023
Merged

mgr/dashboard: create subvolume groups #52886

merged 1 commit into from
Aug 10, 2023

Conversation

Pegonzal
Copy link
Contributor

@Pegonzal Pegonzal commented Aug 9, 2023

Fixes: https://tracker.ceph.com/issues/62363

screen-capture-_16_.mp4

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Pegonzal Pegonzal requested a review from a team as a code owner August 9, 2023 00:10
@Pegonzal Pegonzal requested review from aaSharma14 and nizamial09 and removed request for a team August 9, 2023 00:10
nizamial09
nizamial09 reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have forgot to commit the changes of the form because its not in here!

src/pybind/mgr/dashboard/frontend/src/app/shared/api/cephfs-subvolume-group.service.ts Outdated Show resolved Hide resolved
@Pegonzal Pegonzal force-pushed the cephfs-sbuvolumegroup-create branch from d8ca328 to 895292f Compare August 9, 2023 09:25
@cloudbehl
Copy link
Contributor

cloudbehl commented Aug 9, 2023 •
edited

Hey Pedro, thanks for the PR.
Screencast from 2023-08-09 15-14-54.webm

Nit: in some places we are using Subvolumegroup I think group is a different word so we can make it Subvolume group.
Screenshot from 2023-08-09 15-08-46

Also the notification gives Created subvolumegroup 'undefined'.

@nizamial09 nizamial09 mentioned this pull request Aug 10, 2023
Merged
14 tasks
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@Pegonzal Pegonzal force-pushed the cephfs-sbuvolumegroup-create branch from 895292f to 2b891f6 Compare August 10, 2023 06:31
@Pegonzal Pegonzal force-pushed the cephfs-sbuvolumegroup-create branch from 2b891f6 to a8f82a2 Compare August 10, 2023 07:01
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@Pegonzal
Copy link
Contributor Author

Hey Pedro, thanks for the PR. Screencast from 2023-08-09 15-14-54.webm

Nit: in some places we are using Subvolumegroup I think group is a different word so we can make it Subvolume group. Screenshot from 2023-08-09 15-08-46

Also the notification gives Created subvolumegroup 'undefined'.

Thanks Ankush for noticing, I corrected the texts.

@Pegonzal
mgr/dashboard: create subvolumegroup
c5e39cb 
Fixes: https://tracker.ceph.com/issues/62363
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
@Pegonzal Pegonzal force-pushed the cephfs-sbuvolumegroup-create branch from a8f82a2 to c5e39cb Compare August 10, 2023 07:12
avanthakkar
avanthakkar approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cloudbehl
cloudbehl approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@cloudbehl cloudbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Pegonzal

@Pegonzal Pegonzal merged commit 141cb3d into ceph:main Aug 10, 2023
11 of 13 checks passed
@Pegonzal Pegonzal deleted the cephfs-sbuvolumegroup-create branch August 10, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudbehl cloudbehl cloudbehl approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14 aaSharma14 is a code owner automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
api-change dashboard pybind
Projects
None yet
Milestone
No milestone
4 participants
@Pegonzal @cloudbehl @avanthakkar @nizamial09