Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard:delete image fail on dashboard while it has some protected snapshots #52901

Closed
wants to merge 1 commit into from

Conversation

tengjie5
Copy link
Contributor

@tengjie5 tengjie5 commented Aug 9, 2023

Fixes: https://tracker.ceph.com/issues/62047
Signed-off-by: teng jie tengjie5@asiainfo.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@tengjie5 tengjie5 requested a review from a team as a code owner August 9, 2023 10:01
@tengjie5 tengjie5 requested review from aaSharma14 and nizamial09 and removed request for a team August 9, 2023 10:01
@tengjie5
Copy link
Contributor Author

@aaSharma14 @nizamial09 hi,would you please review the PR ?thanks.

@aaSharma14
Copy link
Contributor

@aaSharma14 @nizamial09 hi,would you please review the PR ?thanks.

Hi @tengjie5 , Thanks for the contribution, will check it out

@Pegonzal
Copy link
Contributor

Hi @tengjie5!

I was checking this PR, and I was trying to reproduce the issue as you stated in tracker but I wasn't able to do so.
Could you attach some logs of the error? It'd be great to see what's going on,

regarding the fix, looks good to me, but may be a 1 second sleep might be too much of a wait?

@tengjie5
Copy link
Contributor Author

@Pegonzal hi, Maybe your hosts have better performance,I suggest creating more snapshots to reproduce the issue.
The dashboard only reported an error log: “Failed to delete RBD 'pool/image' RBD 'pool/image' is busy.”
About the duration of sleep,completing the operation often takes more than one second.

Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 26, 2023
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants