pacific: vstart_runner: maintain log level when --debug is passed #52977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0ste
force-pushed
the
wip-51654-pacific
branch
from
3e10a25
to
9ae1f7b
Compare
When --debug and --clear-old-log options are passed to vstart_runner.py, it ends up resetting log level to the default level (which is logging.INFO) despite of --debug. Set "log_level" as default parameter to init_log() so that the log level code for clearing old log can pass current logging level to init_log() to maintain the log level user desired for. Fixes: https://tracker.ceph.com/issues/51344 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 73567a1)
k0ste
force-pushed
the
wip-51654-pacific
branch
from
9ae1f7b
to
107b936
Compare
ljflores
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/51654
backport of #42030
parent tracker: https://tracker.ceph.com/issues/51344
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh