pacific: rgw: use unique_ptr for flat_map emplace in BucketTrimWatche #52996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0ste
force-pushed
the
wip-59026-pacific
branch
from
63c8432
to
a8efbd8
Compare
When emplacing objects into the trim notify handler of BucketTrimWatcher, use a unique_ptr for the handler so that it is destroyed if the emplace fails. Though the destructor is already called, this behaviour cannot be relied upon. std::map does not exhibit the same behaviour, and would have leaked memory had it been used instead. Fixes: https://tracker.ceph.com/issues/57938 Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com> (cherry picked from commit 43ef475)
k0ste
force-pushed
the
wip-59026-pacific
branch
from
a8efbd8
to
bfdf19b
Compare
|
jenkins test api |
cbodley
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59026
backport of #50346
parent tracker: https://tracker.ceph.com/issues/57938
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh