Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "mds: align quota.max_bytes to 4MB or 4KB" #53153

Merged
merged 1 commit into from Sep 13, 2023
Merged

Revert "mds: align quota.max_bytes to 4MB or 4KB" #53153

merged 1 commit into from Sep 13, 2023

Conversation

vshankar
Copy link
Contributor

Reverts #46905 -- for testing purpose.

@vshankar
Copy link
Contributor Author

I ran this through fs suite and none of the failures are quota related. @lxbsz

@vshankar vshankar mentioned this pull request Aug 31, 2023
Merged
14 tasks
@lxbsz
Copy link
Member

lxbsz commented Aug 31, 2023

I ran this through fs suite and none of the failures are quota related. @lxbsz

Okay, if it won't break anything we can revert it first.

@vshankar
Copy link
Contributor Author

I ran this through fs suite and none of the failures are quota related. @lxbsz

Okay, if it won't break anything we can revert it first.

https://tracker.ceph.com/issues/56397 isn't backported to any release yet, so, I think its safe to revert.

@vshankar vshankar marked this pull request as ready for review August 31, 2023 05:45
@vshankar vshankar requested a review from a team as a code owner August 31, 2023 05:45
@lxbsz
Copy link
Member

lxbsz commented Aug 31, 2023

I ran this through fs suite and none of the failures are quota related. @lxbsz

Okay, if it won't break anything we can revert it first.

https://tracker.ceph.com/issues/56397 isn't backported to any release yet, so, I think its safe to revert.

Sure, I will include this PR again in another PR.

@vshankar
Copy link
Contributor Author

vshankar commented Sep 5, 2023

Update with signed-off-by tag.

@lxbsz I'm merging this. Please push an updated PR for the same.

@lxbsz
Copy link
Member

lxbsz commented Sep 5, 2023

Update with signed-off-by tag.

@lxbsz I'm merging this. Please push an updated PR for the same.

Sure @vshankar.

@vshankar
Copy link
Contributor Author

vshankar commented Sep 5, 2023

Unrelated jenkins test failures :/

@vshankar
Copy link
Contributor Author

vshankar commented Sep 6, 2023

jenkins retest this please

@vshankar
Revert "mds: align quota.max_bytes to 4MB or 4KB"
6d8cb29 
This seems to be causing quota related test failures in the fs
suoite. @lxbsz will push a separate PR addressing the issue in
tracker #56397.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar
Copy link
Contributor Author

vshankar commented Sep 6, 2023

rebased and pushed - no changes, need to trigger full jenkins test.

@vshankar
Copy link
Contributor Author

vshankar commented Sep 7, 2023

jenkins test api

1 similar comment
@vshankar
Copy link
Contributor Author

vshankar commented Sep 7, 2023

jenkins test api

@vshankar
Copy link
Contributor Author

vshankar commented Sep 8, 2023

This is ready to merge, but I lost the run wiki that I had recorded locally - need to do that again :/

@vshankar
Copy link
Contributor Author

https://pulpito.ceph.com/vshankar-2023-09-11_04:57:08-fs-wip-vshankar-testing-20230908.065909-testing-default-smithi/

vshankar added a commit to vshankar/ceph that referenced this pull request Sep 12, 2023
@vshankar
Merge PR ceph#53153 into wip-vshankar-testing-20230908.065909
e404b58 
* refs/pull/53153/head:
	Revert "mds: align quota.max_bytes to 4MB or 4KB"

Reviewed-by: Xiubo Li <xiubli@redhat.com>
@vshankar
Copy link
Contributor Author

https://tracker.ceph.com/projects/cephfs/wiki/Main#13-Sep-2023

@vshankar vshankar merged commit 59d1f76 into main Sep 13, 2023
11 checks passed
@vshankar vshankar deleted the revert-46905-wip-quota branch September 13, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxbsz lxbsz lxbsz approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System documentation tests
Projects
None yet
Milestone
No milestone
2 participants
@vshankar @lxbsz