Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: mds/Server: mark a cap acquisition throttle event in the request #53169

Merged
merged 1 commit into from Nov 9, 2023

Conversation

leonid-s-usov
Copy link
Contributor

@leonid-s-usov leonid-s-usov commented Aug 27, 2023

Fixes: https://tracker.ceph.com/issues/62572
Signed-off-by: Leonid Usov leonid.usov@ibm.com
(cherry picked from commit 749c770)

Parent ticket: https://tracker.ceph.com/issues/59067
Parent PR: #52676


This PR doesn't include the snapdiff modification and the corresponding tests, since this functionality isn't available in pacific

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

…uest

Fixes: https://tracker.ceph.com/issues/62572
Signed-off-by: Leonid Usov <leonid.usov@ibm.com>
(cherry picked from commit 749c770)
@rishabh-d-dave
Copy link
Contributor

@leonid-s-usov Links to parent tracker ticket and parent PR was missing here too. Please add them when you create PR. Backport PR script does it automatically, I hope you are using it.

@rishabh-d-dave
Copy link
Contributor

@leonid-s-usov Comparing to parent/original PR, huge chunks of code are not on this backport PR. And there's no mention about this in the commit message. Please add a note so that the reviewers as well as someone referring to this commit in future will the know the reason behind it.

@leonid-s-usov
Copy link
Contributor Author

I'm not using the script, I run the commands manually.
I didn't know that parent ticket was necessary. I Include the link to the backport ticket which in turn always references the parent ticket.
Is there a well-defined template for what backport PR should look like?

@leonid-s-usov
Copy link
Contributor Author

Comparing to parent/original PR, huge chunks of code are not on this backport PR. And there's no mention about this in the commit message.

The missing code is one line from the Server.cc and the corresponding tests (many lines). The reason is that snapdiff functionality isn't present on this branch - at least that's what it looked like. Hence the backport had to omit those.

@rishabh-d-dave
Copy link
Contributor

Comparing to parent/original PR, huge chunks of code are not on this backport PR. And there's no mention about this in the commit message.

The missing code is one line from the Server.cc and the corresponding tests (many lines). The reason is that snapdiff functionality isn't present on this branch - at least that's what it looked like. Hence the backport had to omit those.

Okay, got it. Please add this explanation for future reference

@batrick batrick modified the milestones: pacific, v16.2.15 Nov 8, 2023
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuriw yuriw merged commit 7eee59a into ceph:pacific Nov 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants