Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: subvolume rm with snapshots #53182

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Pegonzal
Copy link
Contributor

@Pegonzal Pegonzal commented Aug 28, 2023

Fixes: https://tracker.ceph.com/issues/62452
Add option to delete subvolume that have snapshots

screen-capture.25.mp4

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Pegonzal Pegonzal requested a review from a team as a code owner August 28, 2023 13:22
@Pegonzal Pegonzal requested review from avanthakkar and pereman2 and removed request for a team August 28, 2023 13:22
Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pegonzal! left a couple of reviews

Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pegonzal, this looks almost perfect.

I noticed some weird behaviour with the critical-confirmation modal. If you click the Cancel button for the first time in the modal it's giving an error in the console log. I checked and it looks like something I introduced a while ago. The fix would be easy, would you mind adding that here?

this line needs to be
(backActionEvent)="backAction ? callBackAction() : hideModal()"

also, another thing is that it says Unknown Task in the notification message
Screenshot from 2023-08-29 11-55-32

Unrelated bug (could be dealt in a separate PR): The path is /unknown/.../unknown when removed, but ideally it should be empty.
Screenshot from 2023-08-29 11-54-51

@Pegonzal
Copy link
Contributor Author

Thanks for the reviews @nizamial09, I fixed everything you mentioned on this PR itself, let me know what you think

Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Lgtm! Thank you @Pegonzal

@nizamial09
Copy link
Member

nizamial09 commented Aug 29, 2023

1) CephFS Subvolume management
       Remove a CephFS Subvolume:
     CypressError: `cy.click()` can only be called on a single element. Your subject contained 2 elements. Pass `{ multiple: true }` if you want to serially click each element.

Looks like the e2e is failing and we'll need to adapt it. Earlier there were only one checkbox so using the class custom-control-input was enough to tick the checkbox. But since this is adding one more checkbox in the modal we should start using the id instead of the class name. Using the id is anyways better than class name.

This line needs to be modified. Probably to something like
cy.get('cd-modal input#confirmation').click();

Fixes: https://tracker.ceph.com/issues/62452
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Copy link
Contributor

@aaSharma14 aaSharma14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nizamial09 nizamial09 merged commit 9051031 into ceph:main Aug 31, 2023
12 of 13 checks passed
@nizamial09 nizamial09 deleted the fix-subvolume-rm-snapshots branch August 31, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants