Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: fix cephfs create form validator #53208

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Aug 29, 2023

dashboard was allowing to create a filesystem with / in its name but the cli throws out error in doing so. And the created volume in dashboard just gets ended up as a stale volume

Screenshot from 2023-08-29 19-43-40

Fixes: https://tracker.ceph.com/issues/62628

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

dashboard was allowing to create a filesystem with / in its name but the
cli throws out error in doing so. And the created volume in dashboard
just gets ended up as a stale volume

Fixes: https://tracker.ceph.com/issues/62628
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09 nizamial09 requested a review from a team as a code owner August 29, 2023 14:18
@nizamial09 nizamial09 requested review from aaSharma14 and Pegonzal and removed request for a team August 29, 2023 14:18
@nizamial09 nizamial09 merged commit a3630d2 into ceph:main Aug 30, 2023
16 of 18 checks passed
@nizamial09 nizamial09 deleted the fs-volume-validator-fix branch August 30, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants