Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: add nested-name-specifier ThreadPool before WorkQueueVal #5338

Merged
merged 1 commit into from Jul 28, 2015
Merged

common: add nested-name-specifier ThreadPool before WorkQueueVal #5338

merged 1 commit into from Jul 28, 2015

Conversation

hjwsm1989
Copy link
Contributor

Fixes: #12459

Signed-off-by: huangjun hjwsm1989@gmail.com

@hjwsm1989
common: add nested-name-specifier ThreadPool before WorkQueueVal
824c541 
  Fixes: ceph#12459

  Signed-off-by: huangjun <hjwsm1989@gmail.com>
@hjwsm1989
Copy link
Contributor Author

@tchaikov could you have time to review this?

@tchaikov tchaikov self-assigned this Jul 24, 2015
@tchaikov
Copy link
Contributor

i posted my question on tracker

what compiler are you using, and may i have its version? i am not able to reproduce your problem, though.

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6636/

@hjwsm1989
Copy link
Contributor Author

hi, kefu
gcc version 4.4.7 20120313 (Red Hat 4.4.7-4) (GCC)

@tchaikov
Copy link
Contributor

thanks, i think i can reproduce it at http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-rpm-centos6-5-amd64-basic/log.cgi?log=11e313e5ccf54eca340056d3ae5bf57630fd44e6 .

@tchaikov
Copy link
Contributor

i pushed it to wip-5338, so your change can be confirmed by the gitbuilder. once gitbuilder is happy, this pull request is considered good to merge.

tchaikov added a commit that referenced this pull request Jul 28, 2015
@tchaikov
Merge pull request #5338 from hjwsm1989/wip-12459
72d1859 
common/WorkQueue: fix the FTBFS with GCC 4.4.7

* add nested-name-specifier ThreadPool before WorkQueueVal

Reviewed-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit 72d1859 into ceph:master Jul 28, 2015
@tchaikov
Copy link
Contributor

confirmed at http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-rpm-centos6-5-amd64-basic/#origin/wip-5338 .

@hjwsm1989
Copy link
Contributor Author

thanks

@hjwsm1989 hjwsm1989 deleted the wip-12459 branch July 28, 2015 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tchaikov tchaikov

Labels
bug-fix common
Projects
None yet
Milestone
No milestone
4 participants
@hjwsm1989 @tchaikov @loic-bot @smithfarm