Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix bootstrap script for cephadm installation #53436

Merged
merged 1 commit into from Oct 4, 2023
Merged

mgr/dashboard: fix bootstrap script for cephadm installation #53436

merged 1 commit into from Oct 4, 2023

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented Sep 13, 2023 •
edited

Recent refactoring of cephadm files broke the cephadm installation for dashboard cephadm e2e jenkins jobs.
More description about issue: #53052 (comment).
The PR fixes this issue by generating cephadm binaries under ceph_dev_folder src and symlink to /root/bin/cephadm

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@avanthakkar avanthakkar requested a review from a team as a code owner September 13, 2023 11:19
@avanthakkar avanthakkar requested review from aaSharma14 and nizamial09 and removed request for a team September 13, 2023 11:19
phlogistonjohn
phlogistonjohn reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to suggest you move from build.sh to build.py while making these changes. build.sh is currently a trivial wrapper around build.py and at some point it would be nice to simply remove it.

@avanthakkar avanthakkar force-pushed the fix-bootstrap-script branch 4 times, most recently from fb18bfa to 3022583 Compare September 13, 2023 21:17
@avanthakkar avanthakkar force-pushed the fix-bootstrap-script branch 2 times, most recently from 94dda26 to 22f4c13 Compare September 14, 2023 09:58
@avanthakkar avanthakkar force-pushed the fix-bootstrap-script branch 2 times, most recently from d17a0c1 to 70b2b15 Compare September 15, 2023 06:57
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@avanthakkar avanthakkar force-pushed the fix-bootstrap-script branch 3 times, most recently from d5a5844 to 58dda22 Compare September 20, 2023 07:47
@avanthakkar avanthakkar requested a review from a team as a code owner September 20, 2023 10:01
adk3798
adk3798 reviewed Sep 22, 2023
View reviewed changes
src/cephadm/cephadm.py Outdated Show resolved Hide resolved
@nizamial09 nizamial09 mentioned this pull request Sep 26, 2023
Merged
14 tasks
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member

jenkins test api

1 similar comment
@avanthakkar
Copy link
Contributor Author

jenkins test api

@nizamial09 nizamial09 merged commit db8fb4d into ceph:main Oct 4, 2023
11 of 13 checks passed
@nizamial09 nizamial09 deleted the fix-bootstrap-script branch October 4, 2023 13:13
@nizamial09
Copy link
Member

Thanks @avanthakkar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn left review comments

@adk3798 adk3798 adk3798 left review comments

@nizamial09 nizamial09 nizamial09 approved these changes

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14 aaSharma14 is a code owner automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
cephadm dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Milestone
No milestone
4 participants
@avanthakkar @nizamial09 @phlogistonjohn @adk3798