Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: mds: fix deadlock between unlinking and linkmerge #53495

Merged
merged 6 commits into from Nov 15, 2023
Merged

pacific: mds: fix deadlock between unlinking and linkmerge #53495

merged 6 commits into from Nov 15, 2023

Commits on Sep 18, 2023

  1. Revert "mds: wait the linkmerge/migrate to finish after unlink" 

    This reverts commit 48f9a89.

Fixes: https://tracker.ceph.com/issues/61818
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit a9dd5df)
    @lxbsz
    lxbsz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3b0e202 View commit details
    Browse the repository at this point in the history

  2. Revert "mds: notify the waiters in replica MDSs" 

    This reverts commit 478db14.

Fixes: https://tracker.ceph.com/issues/61818
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 84c7da7)
    @lxbsz
    lxbsz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    0ac5729 View commit details
    Browse the repository at this point in the history

  3. Revert "mds: wait reintegrate to finish when unlinking" 

    This reverts commit c3b3672.

Fixes: https://tracker.ceph.com/issues/61818
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit b0b279a)
    @lxbsz
    lxbsz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1a72cb4 View commit details
    Browse the repository at this point in the history

  4. Revert "mds: clear the STATE_UNLINKING state when the unlink fails" 

    This reverts commit 417f247.

Fixes: https://tracker.ceph.com/issues/61818
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 4ec2b03)
    @lxbsz
    lxbsz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    fd8f7c0 View commit details
    Browse the repository at this point in the history

  5. Revert "mds: wait unlink to finish to avoid conflict when creating sa… 

    …me dentries"

This reverts commit 76b099b.

Fixes: https://tracker.ceph.com/issues/61818
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 8e24030)
Conflicts:
    src/messages/MDentryUnlink.h
    @lxbsz
    lxbsz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    cc4c79a View commit details
    Browse the repository at this point in the history

  6. mds: continue linking if targeti is temporarily located in stray dir 

    If one inode has more than one hardlink and after the primary dentry
is unlinked it will located the inode in the stray dir temporarily,
which is pending reintegration.

Just before the linkmerge/migrate is triggered a link request comes
it will fail with -EXDEV.

Just skip it and continue the linking.

Fixes: https://tracker.ceph.com/issues/56695
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 5b9df82)
    @lxbsz
    lxbsz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e921cc4 View commit details
    Browse the repository at this point in the history