quincy: pybind/mgr/pg_autoscaler: fix warn when not too few pgs

[kamoltat]

Problem:

when pg_num_final is equal to pg_num_target
we get too many PGs warnings in ceph health while
warn mode in the autoscaler.

Solution:

Get rid of else condition and add an
elif p['pg_num_final'] < p['pg_num_target']
instead

Fixes: https://tracker.ceph.com/issues/61570

Backporting relevant commits from main PR:

#51923

Signed-off-by: Kamoltat ksirivad@redhat.com

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[ljflores]

jenkins test make chck

[kamoltat]

Make check fail is unrelated, cephadm stuff:

        def _crush_location_checker(ctx, fsid, daemon_type, daemon_id, container, uid, gid, **kwargs):
            print(container.args)
            raise Exception(' '.join(container.args))
    
        _deploy_daemon.side_effect = _crush_location_checker
    
>       with pytest.raises(Exception, match='--set-crush-location database=a'):
E       AssertionError: Regex pattern did not match.
E        Regex: '--set-crush-location database=a'
E        Input: "Failed to extract uid/gid for path /var/lib/ceph: Failed command: /usr/bin/docker run --rm --ipc=host --stop-signal=SIGTERM --ulimit nofile=1048576 --net=host --entrypoint stat --init -e CONTAINER_IMAGE=quay.io/ceph/ceph:v17 -e NODE_NAME=braggi17.front.sepia.ceph.com -e CEPH_USE_RANDOM_NONCE=1 quay.io/ceph/ceph:v17 -c %u %g /var/lib/ceph: docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.\nSee 'docker run --help'.\n"

tests/test_cephadm.py:343: AssertionError

[kamoltat]

jenkins test make check

[kamoltat]

jenkins test make chck

[yuriw]

jenkins test make check

[yuriw]

@kamoltat pls merge when all checks passed
ref: https://trello.com/c/vB5XcEdi

[vshankar]

@ljflores leave it for you to merge.